[$250] mweb - Merge account - Merge account button overlaps with magic code field

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.24-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #56911
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: User Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Settings > Security.
3. Tap Merge account.
4. Enter email of another account.
5. Mark "I understand this is not reversible" checkbox.
6. Click Next.
7. Tap on magic code field.

Expected Result:

Merge account button will not overlap with magic code field.

Actual Result:

Merge account button overlaps with magic code field. The page is not scrollable when keyboard is opened.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6795536_1744070323779.Screen_Recording_20250408_075705_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021909751357892939388
• Upwork Job ID: 1909751357892939388
• Last Price Increase: 2025-04-08

Issue Owner

Current Issue Owner: @neil-marcellini

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[luacmartins]

Doesn't seem like an API blocker

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021909751357892939388

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[thelullabyy]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-09 02:37:25 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Merge account button overlaps with magic code field. The page is not scrollable when keyboard is opened.

What is the root cause of that problem?

When the keyboard is so big, there is not enough space to display both the error message and the description text. It caused the content to overlap

What changes do you think we should make in order to solve the problem?

To avoid any overlapping issues when content exceeds the available space, I recommend placing everything within a scrollable container. This will allow the content to extend downwards as needed.

 <ScrollView
                    style={[themeStyles.w100, themeStyles.h100, themeStyles.flex1]}
                    contentContainerStyle={themeStyles.flexGrow1}
                    keyboardShouldPersistTaps="handled"
                >

Add a ScrollView component to this place

App/src/components/ValidateCodeActionForm/index.tsx

Line 52 in 563386f

<View style={[themeStyles.ph5, themeStyles.mt3, themeStyles.mb5, themeStyles.flex1]}>

Alternatively, we can place a ScrollView here to prevent the header text from scrolling.

App/src/components/ValidateCodeActionModal/ValidateCodeForm/BaseValidateCodeForm.tsx

Line 227 in fbcd7dd

<>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[DylanDylann]

@thelullabyy's proposal looks good to me

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @neil-marcellini, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[allroundexperts]

This is part of the Merge account project. Me and @parasharrajat are fixing these.

[neil-marcellini]

@allroundexperts do you have an existing issue that will handle this? If so we can close this issue as a duplicate. If not, please link me to the merge account project tracking issues and then I can assign you to fix this one.

[allroundexperts]

We're handling this as part of #47073. I don't think there's a dup issue for this.

[neil-marcellini]

Do you want to review and use the proposal here or not? Let me know if I should review it, and I can review the PR either way.

[allroundexperts]

@neil-marcellini There is no need to review the proposal here. This is being done as part of the Merge Accounts feature project.