Skip to content

Conflict with TouchUI plug-in #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gobbledygoober opened this issue Jul 5, 2021 · 6 comments
Closed

Conflict with TouchUI plug-in #188

gobbledygoober opened this issue Jul 5, 2021 · 6 comments
Labels
status: closedByBot status: markedForAutoClose Issue will be closed automatically status: waitingForTestFeedback type: bug Something isn't working

Comments

@gobbledygoober
Copy link

gobbledygoober commented Jul 5, 2021 •
edited
Loading

There appears to be a bug related to Octoprint installations that have SpoolManager and TouchUI plugins installed.

The issue was originally reported on the TouchUI GitHub, but the author marked the issue as Closed because they could not address it within their codebase:

BillyBlaze/OctoPrint-TouchUI#500 (comment)

If both plugins are installed, on the touch interface, links that are visible only after scrolling are unclickable.

By process of elimination, disabling the SpoolManager plug-in allowed the touch interface to work as expected. The author suggested that:

I have tracked down the code that is interfering. Inside SpoolManager there is a plugin named 'pick-a-color.js'. This piece of code called executeUnlessScrolled (its even in the name) is preventing the items to be clicked after scrolling on a touch device.

Wondering if this can be easily addressed on the SpoolManager side. Thanks for reading.
@gobbledygoober gobbledygoober mentioned this issue Jul 5, 2021
Closed
@OllisGit OllisGit added the status: inNextRelease Will be implemented/fixed in next release label Oct 24, 2021
OllisGit added a commit that referenced this issue Oct 24, 2021
@OllisGit
New Version 1.5.0
b1d9080 
- PR #204, #201 redesign of the Spool-Selection in the sidebar. Huge thanks to @TiziG @MarloSM
- E #125 New field "Serialnumber"
- E Spool selection from Edit-Dialog
- E #141 New Filter: Material, Vendor and Color
- E #44 Sidebar filament usage in grams instead of volume

- B #199, #198, #163, #156 some QR-Code optimisations
- B #197, #196, #188, #181, #178, #177, #172, #162, #142,  Some UI optimisations
- B #194 CSV import, behind reverse proxy
- B #175 Confirm dialog not shown
@OllisGit
Copy link
Owner

Hi @gobbledygoober,

I changed the UI behaviour in the lates release 1.5.0, maybe the problem is also now fixed in your setup.

Please try and give feedback
Olli

@OllisGit OllisGit added status: waitingForTestFeedback and removed status: inNextRelease Will be implemented/fixed in next release labels Oct 24, 2021
@Nazar78
Copy link

Nazar78 commented Nov 5, 2021 •
edited
Loading

Hi @OllisGit,

I'm also experiencing the exact issue even with the latest v1.5.0. The menus within TouchUI aren't clickable upon scrolling. The issue went away only after disabling Spool Manager. Think there's not much feedback because users will just disable/uninstall Spool Manager when they face this issue? However I still love to use this plugin due to its simplify of sqlite3 over external db although I do have a dedicated mariadb at disposal.

Thank you.

Edited: not sure how the issue is going to be fixed because it involves another 3rd party dependency but I temporarily changed the "return false;" to just "return;" in

OctoPrint-SpoolManager/octoprint_SpoolManager/static/js/pick-a-color.js

Line 786 in b1d9080

return false;

@OllisGit
Copy link
Owner

OllisGit commented Jan 7, 2022

I was able to reproduce the issue. In the next release your suggestion will be im implemented. Thx, for analysing!!!

@OllisGit OllisGit added status: inNextRelease Will be implemented/fixed in next release and removed status: waitingForTestFeedback labels Jan 7, 2022
OllisGit added a commit that referenced this issue Jan 12, 2022
@OllisGit
New Version 1.6.0
02e6231 
- E release-channles
- E stale-bot via github-actions
- E #79, #87, #99, #119, #157, #176, #202, weight calculation during editing PR #206, thx al lot @TiziG
- E #106 switching from travis to github-actions
- E #107, #215 database-settings in the log will only be shown, if sql-logging is enabled
- E #170 inform user about switching a spool already selected
- E #213 sort/filter options in spool selection dialog
- E Extrusion-Debugging: Show current extrusion during printing

- B #188 touchUI conflict
- B #193, #196 sorting/showing of remaining weight
- B #205 changed to "browser-native" date/time picker
- B #210 loadCatalogColors when color name is blank
- B #211 button text changed
- B #212 import CSV only if printer in idle-mode
- B #216 FilamentManager and SpoolManager used same viewmodel
- B #217 when print is paused the extruded filament is assigned to the spool and the counter is reseted
@OllisGit
Copy link
Owner

Hi,
in the latest version the issue should be fixed.
Please test and give a feedback.

Thx in advance
Olli

@OllisGit OllisGit added status: waitingForTestFeedback type: bug Something isn't working and removed status: inNextRelease Will be implemented/fixed in next release labels Jan 12, 2022
@github-actions
Copy link

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

@github-actions github-actions bot added the status: markedForAutoClose Issue will be closed automatically label Feb 13, 2022
@github-actions
Copy link

This issue was closed, because it has been already marked for 10 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: closedByBot status: markedForAutoClose Issue will be closed automatically status: waitingForTestFeedback type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Nazar78 @OllisGit @gobbledygoober