Skip to content

Filament usage amount is wrong when print is paused #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hvraven opened this issue Nov 17, 2021 · 3 comments
Closed

Filament usage amount is wrong when print is paused #217

hvraven opened this issue Nov 17, 2021 · 3 comments
Labels

Comments

@hvraven
Copy link

hvraven commented Nov 17, 2021

When a print is paused mid print (in my case using M600 to insert a part into the printed piece) the plugin counts the filament usage wrong. I did not change the spool during the pause, maybe when changing the spool this does not happen.

Based on the amounts I've seen it appears that on pause the filament used so far is subtracted from the spool and in the end the whole amount is subtracted again.

I looked a bit into the code and it appears that the filament counter is only reset on the start of the print. There is a reset the commit function, but it is commented out. I don't see why, for me it would make sense to reset there, but I am also lacking an overview of the full code base.

# self.myFilamentOdometer.reset()

@hvraven hvraven changed the title Filament usage is wrong when print is paused Filament usage amount is wrong when print is paused Nov 17, 2021
@OllisGit OllisGit added status: analysing type: bug Something isn't working status: inProgress I am working on it status: inNextRelease Will be implemented/fixed in next release and removed status: analysing status: inProgress I am working on it labels Jan 7, 2022
OllisGit added a commit that referenced this issue Jan 12, 2022
- E release-channles
- E stale-bot via github-actions
- E #79, #87, #99, #119, #157, #176, #202, weight calculation during editing PR #206, thx al lot @TiziG
- E #106 switching from travis to github-actions
- E #107, #215 database-settings in the log will only be shown, if sql-logging is enabled
- E #170 inform user about switching a spool already selected
- E #213 sort/filter options in spool selection dialog
- E Extrusion-Debugging: Show current extrusion during printing

- B #188 touchUI conflict
- B #193, #196 sorting/showing of remaining weight
- B #205 changed to "browser-native" date/time picker
- B #210 loadCatalogColors when color name is blank
- B #211 button text changed
- B #212 import CSV only if printer in idle-mode
- B #216 FilamentManager and SpoolManager used same viewmodel
- B #217 when print is paused the extruded filament is assigned to the spool and the counter is reseted
@OllisGit
Copy link
Owner

Hi @hvraven,
in the latest version the issue should be fixed.
Please test and give a feedback.

Thx in advance
Olli

@OllisGit OllisGit added status: waitingForTestFeedback and removed status: inNextRelease Will be implemented/fixed in next release labels Jan 12, 2022
@github-actions
Copy link

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

@github-actions
Copy link

This issue was closed, because it has been already marked for 10 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants