Skip to content

Change spool dialog doesnt match selectable options #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
elminster opened this issue Oct 26, 2021 · 5 comments
Closed

Change spool dialog doesnt match selectable options #211

elminster opened this issue Oct 26, 2021 · 5 comments

Comments

@elminster
Copy link

elminster commented Oct 26, 2021 •
edited
Loading

Minor bug but when you change spool mid-print the dialogue box gives the wrong option names.

'You are changing a spool while printing. SpoolManager will commit the usage so far to the previous spool, unless you wish otherwise ....'

You are asked to click either 'Ok' or 'Abort'

but the dialog box buttons are labelled 'cancel and 'ok'

image
@OllisGit
Copy link
Owner

Hi @elminster,
thanks for the report. I tried to reproduce the error, but in my environment it look like this (German Local):
image

What browser do you use?

JavaScript confirm-function testpage: https://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_confirm

@OllisGit
Copy link
Owner

ah....I started a VirtualBox and see this:
image

Jap, will change 'Abort' to 'Cancel'

@OllisGit OllisGit added the status: inNextRelease Will be implemented/fixed in next release label Oct 27, 2021
@elminster
Copy link
Author

Just to answer the first bit, I am using Firefox 93 on Ubuntu 20LTS, and region/lang all English(UK/British).

Not something I do often, just noticed it the other day, when I forgot to change the spool over.

@eacxx
Copy link

eacxx commented Dec 22, 2021

image
Firefox 95 on macOS Big Sur.

OllisGit added a commit that referenced this issue Jan 12, 2022
@OllisGit
New Version 1.6.0
02e6231 
- E release-channles
- E stale-bot via github-actions
- E #79, #87, #99, #119, #157, #176, #202, weight calculation during editing PR #206, thx al lot @TiziG
- E #106 switching from travis to github-actions
- E #107, #215 database-settings in the log will only be shown, if sql-logging is enabled
- E #170 inform user about switching a spool already selected
- E #213 sort/filter options in spool selection dialog
- E Extrusion-Debugging: Show current extrusion during printing

- B #188 touchUI conflict
- B #193, #196 sorting/showing of remaining weight
- B #205 changed to "browser-native" date/time picker
- B #210 loadCatalogColors when color name is blank
- B #211 button text changed
- B #212 import CSV only if printer in idle-mode
- B #216 FilamentManager and SpoolManager used same viewmodel
- B #217 when print is paused the extruded filament is assigned to the spool and the counter is reseted
@OllisGit OllisGit removed the status: inNextRelease Will be implemented/fixed in next release label Jan 12, 2022
@OllisGit
Copy link
Owner

fyi: Button-Text is changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@elminster @OllisGit @eacxx