Skip to content

unable to set a bought on: date #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
themoonisacheese opened this issue Oct 20, 2021 · 19 comments
Closed

unable to set a bought on: date #205

themoonisacheese opened this issue Oct 20, 2021 · 19 comments
Labels
type: bug Something isn't working

Comments

@themoonisacheese
Copy link

when creating a new spool or editing an existing one, if a bought on: date is specified, the changes won't stick or the new spool won't get registered at all. this seems to happen whether the date is in the past or the future.
@OllisGit
Copy link
Owner

Hi @themoonisacheese,

do the following:

  • use chrome browser and open the development tools
  • switch to "network tab"
  • open the spool dialog and enter your data
  • press save and look into the network tab for read line

screenshot the browser and attach it here

@OllisGit OllisGit added the status: waitingForFeedback Wating for Customers feedback label Oct 24, 2021
@themoonisacheese
Copy link
Author

themoonisacheese commented Oct 24, 2021 •
edited
Loading

here is the screenshot.
the response just is standard text for a 500 http error.
image
this is the only field that behaves like this from what i can tell, i've been able to populate all other fields without issue.
this is still the case after updating to the latest version today.

@OllisGit
Copy link
Owner

Hi @themoonisacheese,
looks like the issue is located on the server side and not in the browser.
Please attach the OP-Log file as well.
image

@OllisGit OllisGit added the type: bug Something isn't working label Oct 24, 2021
@themoonisacheese
Copy link
Author

log:
octoprint(1).log

i've re-tried saving my changes to the spool just before generating the log.

@themoonisacheese
Copy link
Author

since the above log is only 64k and seems to cut off like 3 hours ago, i suspected octoeverywhere to at least be interfering with the logs, but it seems it is also interfering with this field. when i look at octoprint from my local network, the field is already populated with "1.11.2021" which is not a date I ever submitted, and submitting a new one is still not working. here's the proper log:
octoprint(2).log

@OllisGit
Copy link
Owner

Well it is a javascript issue. The Datepicker use a wrong format. Maybe a local settings in the browser. What language do you use in the browser?

ValueError: time data '1.41.2021' does not match format '%d.%m.%Y'

@themoonisacheese
Copy link
Author

themoonisacheese commented Oct 24, 2021 via email •
edited
Loading

@OllisGit
Copy link
Owner

Hi @themoonisacheese,

I tried to reproduce the issue with different browsers and browser locals, but without success. Everytime the purchase date was in the correct format.

Please attach a screenshot of the edit dialog after you selected the date and after that also network log-shot from the browser.

@lorez42
Copy link

lorez42 commented Oct 30, 2021

I've had similar problems with the current firefox (93.0). When I select a date for the purchased, for example, say 10/25/2021, it actually fills in 1.36.2021, then throws the datetime format error in the log when trying to save.

@oerkel47
Copy link

oerkel47 commented Nov 2, 2021

Can confirm problems. The first and last used dropdown list also produce a broken time setting. The moment you click on a date it inserts the bugged date into the field. If you type in a date by hand it also parses it to the incorrect date.

grafik
grafik
grafik

@OllisGit
Copy link
Owner

OllisGit commented Nov 3, 2021 •
edited
Loading

Hi @oerkel47,
thanks for providing the screenshots. You and @themoonisacheese and @lorez42 are using Firefox. Is this issue also reproducible with a chrome browser.
I played around with FireFox, different browser locals, but I was not able to reproduce the error.

It looks like that the datetimepicker is also not supported any more and I couldn't find an related issue in tracker.
https://github.com/xdan/datetimepicker

@oerkel47
Copy link

oerkel47 commented Nov 4, 2021

Thanks for looking into it.

Same problem in chrome and on my phones firefox.

@OllisGit
Copy link
Owner

OllisGit commented Nov 4, 2021

hmmm...okay, I think I will switch to the html-standard picker: https://www.w3schools.com/tags/att_input_type_datetime-local.asp
....but the user needs a "modern" browser.

@OllisGit OllisGit added status: inProgress I am working on it and removed status: waitingForFeedback Wating for Customers feedback labels Nov 4, 2021
@themoonisacheese
Copy link
Author

chrome has had support for this for 9 years, but firefox only recently added datetime-local in version 93 this year. maybe the more recent versions that support the standard don't work well with the previous datetime picker?

@oerkel47
Copy link

oerkel47 commented Nov 4, 2021

hmmm...okay, I think I will switch to the html-standard picker: https://www.w3schools.com/tags/att_input_type_datetime-local.asp ....but the user needs a "modern" browser.

As long as the unsupported browsers can still use the manual input that wouldn't be too critical imo.

@tszolar
Copy link

tszolar commented Dec 22, 2021

Can confirm that this happens both in Chrome and Firefox for me. Not sure what is the cause as I should have English locale set.

@OllisGit OllisGit pinned this issue Jan 7, 2022
@OllisGit OllisGit added status: inNextRelease Will be implemented/fixed in next release and removed status: inProgress I am working on it labels Jan 12, 2022
@OllisGit OllisGit unpinned this issue Jan 12, 2022
OllisGit added a commit that referenced this issue Jan 12, 2022
@OllisGit
New Version 1.6.0
02e6231 
- E release-channles
- E stale-bot via github-actions
- E #79, #87, #99, #119, #157, #176, #202, weight calculation during editing PR #206, thx al lot @TiziG
- E #106 switching from travis to github-actions
- E #107, #215 database-settings in the log will only be shown, if sql-logging is enabled
- E #170 inform user about switching a spool already selected
- E #213 sort/filter options in spool selection dialog
- E Extrusion-Debugging: Show current extrusion during printing

- B #188 touchUI conflict
- B #193, #196 sorting/showing of remaining weight
- B #205 changed to "browser-native" date/time picker
- B #210 loadCatalogColors when color name is blank
- B #211 button text changed
- B #212 import CSV only if printer in idle-mode
- B #216 FilamentManager and SpoolManager used same viewmodel
- B #217 when print is paused the extruded filament is assigned to the spool and the counter is reseted
@OllisGit
Copy link
Owner

Hi,
in the latest release I change the date/time-picker to the browser-native implementation. I think this is the best solution...hopefully ;-)

Please test and give a feedback.

Thx in advance,
Olli

@OllisGit OllisGit added status: waitingForTestFeedback and removed status: inNextRelease Will be implemented/fixed in next release labels Jan 12, 2022
@oerkel47
Copy link

The datepicker seems to be working just fine now - thank you.

@tszolar
Copy link

tszolar commented Jan 12, 2022

In the latest version it works great. Thanks a lot!

@mdziekon mdziekon mentioned this issue Jun 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lorez42 @tszolar @themoonisacheese @OllisGit @oerkel47