Skip to content

Mask log-messages #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
OllisGit opened this issue Jan 25, 2021 · 5 comments
Closed

Mask log-messages #107

OllisGit opened this issue Jan 25, 2021 · 5 comments
Labels
status: closedByBot status: markedForAutoClose Issue will be closed automatically status: waitingForTestFeedback type: enhancement New feature or request

Comments

@OllisGit
Copy link
Owner

Like passwords and urls
@OllisGit OllisGit added the type: enhancement New feature or request label Jan 25, 2021
@PowerWiesel
Copy link

Hey 😄
I was about to report that passwords are leaked in the logs and saw that you already have this ticket.
I don't use your plugin but I guess the Olli user is the default one?
If everybody got the same user it's not that bad but if somebody changes the credentials and uploads the logs in a ticket or on the forum it wouldn't be so great.

@OllisGit
Copy link
Owner Author

OllisGit commented Jan 7, 2022

In next release the connection settings logs are only printed, if sql logging is enabled (only for debugging)

@OllisGit OllisGit added the status: inNextRelease Will be implemented/fixed in next release label Jan 7, 2022
OllisGit added a commit that referenced this issue Jan 12, 2022
@OllisGit
New Version 1.6.0
02e6231 
- E release-channles
- E stale-bot via github-actions
- E #79, #87, #99, #119, #157, #176, #202, weight calculation during editing PR #206, thx al lot @TiziG
- E #106 switching from travis to github-actions
- E #107, #215 database-settings in the log will only be shown, if sql-logging is enabled
- E #170 inform user about switching a spool already selected
- E #213 sort/filter options in spool selection dialog
- E Extrusion-Debugging: Show current extrusion during printing

- B #188 touchUI conflict
- B #193, #196 sorting/showing of remaining weight
- B #205 changed to "browser-native" date/time picker
- B #210 loadCatalogColors when color name is blank
- B #211 button text changed
- B #212 import CSV only if printer in idle-mode
- B #216 FilamentManager and SpoolManager used same viewmodel
- B #217 when print is paused the extruded filament is assigned to the spool and the counter is reseted
@OllisGit
Copy link
Owner Author

Hi,
in the latest version the issue should be fixed. Only visible if SQL logging is enabled.
Please test and give a feedback.

Thx in advance
Olli

@OllisGit OllisGit added status: waitingForTestFeedback and removed status: inNextRelease Will be implemented/fixed in next release labels Jan 12, 2022
@github-actions
Copy link

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

@github-actions github-actions bot added the status: markedForAutoClose Issue will be closed automatically label Feb 16, 2022
@github-actions
Copy link

This issue was closed, because it has been already marked for 10 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: closedByBot status: markedForAutoClose Issue will be closed automatically status: waitingForTestFeedback type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PowerWiesel @OllisGit