Skip to content

Confirm dialog sometimes doesn't pop up. #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codingcatgirl opened this issue May 26, 2021 · 15 comments
Closed

Confirm dialog sometimes doesn't pop up. #175

codingcatgirl opened this issue May 26, 2021 · 15 comments
Labels
type: bug Something isn't working

Comments

@codingcatgirl
Copy link
Contributor

As far as i can tell, this is how you should be able to reproduce it: Have a spool already selected and be connected to the printer, then connect to the octoprint interface. Select a print, klick Print → the dialogue will not pop up. Dis/reconnect from/to the printer, klick the print button again, and the confirm dialog will pop up. Weird?

@cicinovec
Copy link

I confirm, after update to 1.4.1 the confirmation pop-up window appeared for the first time, but now not anymore

@OllisGit
Copy link
Owner

Sorry,
I can not reproduce the issue. What I did:

  • Open a fresh browser-tab
  • Load the OP-Interface
  • Printer is autoconnect and no spool is selected
  • Select a spool
  • Close browser tab
  • Load the OP-Interface
  • Select a file
  • Click Print
  • Popup appears

@killernils
Copy link

Just updated to 1.4.3 and stopped getting confirmations/popups on:
"Warn, if no spool is selected."
"Reminder for verifying the selected spool."

Anything I can do to help out?

@cicinovec
Copy link

cicinovec commented May 27, 2021

After updating to 1.4.3 is the dialog back

EDIT: After 3 prints the dialog does not pop-up anymore. Restart of browser does not help. After my current print is finished, I try to reboot the server

@gn0m3r4l
Copy link

gn0m3r4l commented Jun 2, 2021

Same for me.
Plugin Version 1.4.3
Octoprint 1.6.1

Unfortunately, I cannot tell when this occurs first time.

@ales444
Copy link

ales444 commented Jun 2, 2021

Same for me.
Plugin Version 1.4.3
Octoprint 1.6.1

Stopped working recently, not sure exactly when.

@codingcatgirl
Copy link
Contributor Author

I just got thisagain for the first time in days. Still no idea what caused it. Could be a printer that i aborted and then restartet, maybe?

@codingcatgirl
Copy link
Contributor Author

codingcatgirl commented Jun 15, 2021

Sorry to say that this is still happening.

@OllisGit
Copy link
Owner

I have an idea.....the current implementation reads the needed (calculated) filament length for each used tool from the metadata-file (.metadata.json) located in the upload folder.
image

The implementation expect that this data is available after selecting the file for printing.
But this length is calculated depending on the selected strategy in the OP-Settings (Settings / Features).
image

Because at the moment it it just an idea, but you can also test it, if you change to always and/or you can select the file, select an other file and come back to the file....in the meantime the length should be calculated and the popup should appear......a little bit complicated.

I think I will write a patch for that ;-). ....after I can confirm the idea!

@OllisGit OllisGit added status: analysing type: bug Something isn't working labels Jun 17, 2021
@codingcatgirl
Copy link
Contributor Author

Oh, yeah, that sounds like it could be it! Though it might be even simpler… the analysis could simply take a while and not be done yet and that's enough to trigger the bug? The solution would probably be to just assume all slots are used if the analysis isn't done yet

@MrRexRuthless
Copy link

I am having the same issue. I have to deselect a spool to get it to print.

@OllisGit OllisGit added status: inNextRelease Will be implemented/fixed in next release and removed status: analysing labels Oct 19, 2021
OllisGit added a commit that referenced this issue Oct 24, 2021
- PR #204, #201 redesign of the Spool-Selection in the sidebar. Huge thanks to @TiziG @MarloSM
- E #125 New field "Serialnumber"
- E Spool selection from Edit-Dialog
- E #141 New Filter: Material, Vendor and Color
- E #44 Sidebar filament usage in grams instead of volume

- B #199, #198, #163, #156 some QR-Code optimisations
- B #197, #196, #188, #181, #178, #177, #172, #162, #142,  Some UI optimisations
- B #194 CSV import, behind reverse proxy
- B #175 Confirm dialog not shown
@OllisGit
Copy link
Owner

Hi,
in latest release 1.5.0 the issue should be solved

Please try and give me a feedback.
Olli

@OllisGit OllisGit added status: waitingForTestFeedback and removed status: inNextRelease Will be implemented/fixed in next release labels Oct 24, 2021
@cicinovec
Copy link

Hi @OllisGit , I have tested with several prints and it works now properly. It always asks to confirm filament.
Only now I see text Required Filament unknown

obrazek

@OllisGit
Copy link
Owner

Hi @cicinovec!

I added a FAQ-Page in the Wiki that explains the behaviour:
https://github.com/OllisGit/OctoPrint-SpoolManager/wiki/Frequently-asked-questions
Please take a look on that.

Jap, maybe I should change the text....but the text should be short...any idea?

@cicinovec
Copy link

Hi @OllisGit, thank you, now it works nicely.
The text itself is clear, I would not change it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants