Make sidebar collapsible #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After looking at OllisGit#201, I realise that simply removing the overflow won't do. Changing it to #sidebar_plugin_SpoolManager.collapse.in makes it work.
OllisGit
added
the
status: inNextRelease
|
Hi @MarloSM, I tested your PR a couple of days ago it worked for me and I was building a new release, but now I saw that @tiz also changed his/her PR https://github.com/OllisGit/OctoPrint-SpoolManager/pull/201/commits Before I continue building the new release I will take a look on this PR. |
OllisGit
added a commit
that referenced
this pull request
Oct 24, 2021
- PR #204, #201 redesign of the Spool-Selection in the sidebar. Huge thanks to @TiziG @MarloSM - E #125 New field "Serialnumber" - E Spool selection from Edit-Dialog - E #141 New Filter: Material, Vendor and Color - E #44 Sidebar filament usage in grams instead of volume - B #199, #198, #163, #156 some QR-Code optimisations - B #197, #196, #188, #181, #178, #177, #172, #162, #142, Some UI optimisations - B #194 CSV import, behind reverse proxy - B #175 Confirm dialog not shown
OllisGit
removed
the
status: inNextRelease
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After looking at #201, I realise that simply removing the overflow won't do. Addresses #197
Changing it to
#sidebar_plugin_SpoolManager.collapse.inmakes it work.