Skip to content

Deploy Checklist: New Expensify 2025-03-31 #59334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
62 tasks done
github-actions bot opened this issue Mar 31, 2025 · 21 comments
Closed
62 tasks done

Deploy Checklist: New Expensify 2025-03-31 #59334

github-actions bot opened this issue Mar 31, 2025 · 21 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025

Release Version: 9.1.21-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked Firebase Crashlytics for the previous release version and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@gleitebr gleitebr added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Mar 31, 2025
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.1.21-0 🚀

@rlinoz
Copy link
Contributor

rlinoz commented Mar 31, 2025

Demoted #59346

@izarutskaya
Copy link

Regression is at 65% completed.

Unchecked PRs:
#57923 - found bug #57923 (comment) Pending validation on iOS
#58061 - pending validation on Web, mWeb and Desktop
#58362 - facing with issue #58362 (comment)
#58575 - found issue on a Desktop #58575 (comment) Pending validation on iOS

Blockers:
#59352
#59357

@grgia
Copy link
Contributor

grgia commented Mar 31, 2025

Checking off #59384 as dupe

@grgia
Copy link
Contributor

grgia commented Mar 31, 2025

demoted #59404

@grgia
Copy link
Contributor

grgia commented Mar 31, 2025

demoted #59394

@grgia
Copy link
Contributor

grgia commented Mar 31, 2025

@izarutskaya what's the latest % update on regression tests?

@grgia
Copy link
Contributor

grgia commented Mar 31, 2025

Not seeing any Fresh Firebase crashes on this version

IOS

Image

Android

Image

But it does seem like there's been lots of crashes on android the last 7 days.

Top offender seems to be fixed by this version, but the second two are still occurring

Image

@mvtglobally
Copy link

Regression is at 99% completed.

Unchecked PRs:
#58061 - Is failing with #59394. We are unable to check PROD, pls double check if the blocker.
#59160 - Can you pls QA internally? #59160 (comment)

Blockers:
#59352
#59357
#59393

@grgia
Copy link
Contributor

grgia commented Apr 1, 2025

closed as fixed #59432

@grgia
Copy link
Contributor

grgia commented Apr 1, 2025

demoted #59427

@grgia
Copy link
Contributor

grgia commented Apr 1, 2025

checking off #59393 as fixed

@grgia
Copy link
Contributor

grgia commented Apr 1, 2025

checking off #59417 as fixed

@grgia
Copy link
Contributor

grgia commented Apr 1, 2025

One fresh crash on IOS. Nothing in logs for the crash jumping out for RCA in code

TypeError: Cannot read property 'errors' of undefined

Related to onClose() / fetchExpenseList() call

Image

@grgia
Copy link
Contributor

grgia commented Apr 1, 2025

checking off #59352 as fixed

@grgia
Copy link
Contributor

grgia commented Apr 1, 2025

@mvtglobally would you give an update on the unchecked PRs?

@mvtglobally
Copy link

mvtglobally commented Apr 1, 2025

@grgia
Unchecked PRs:
#58061 - Is failing with #59394. We are unable to check PROD, pls double check if its the blocker.
#59160 - Can you pls QA internally? #59160 (comment)

@mvtglobally
Copy link

Regression is completed

@grgia
Copy link
Contributor

grgia commented Apr 1, 2025

checking off #59357 as fixed

@grgia
Copy link
Contributor

grgia commented Apr 1, 2025

Alright... let's do this thang

@grgia
Copy link
Contributor

grgia commented Apr 1, 2025

:shipit:

@grgia grgia closed this as completed Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

6 participants