56951 tax input dot move #58380

huult · 2025-03-13T15:02:19Z

Details

Fixed Issues

$ #56951
PROPOSAL: #56951 (comment)

Tests

Same QA step

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the Expensify app.
Navigate to Workspace Settings.
Tap on More Features.
Enable Tax.
Tap on Add Rate.
Select the Value field.
Enter a digit (e.g., 3).
Enter a decimal point (.).
Verify that the first digit (3) does not move.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-20.at.23.12.41.mov

Android: mWeb Chrome

Screen.Recording.2025-03-13.at.21.22.07.mov

iOS: Native

Screen.Recording.2025-03-20.at.23.35.20.mov

iOS: mWeb Safari

Screen.Recording.2025-03-13.at.21.25.57.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-13.at.21.26.40.mov

MacOS: Desktop

Screen.Recording.2025-03-13.at.21.56.39.mov

…-move

melvin-bot · 2025-03-13T15:02:26Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/AmountForm.tsx

eh2077 · 2025-03-16T11:08:02Z

@huult As this issue mainly occurs on native platform, can you please add recordings for Android and iOS app?

eh2077 · 2025-03-20T04:27:40Z

@huult Friendly bump on PR comments

huult · 2025-03-20T09:36:26Z

I will update it today

huult · 2025-03-20T16:08:19Z

@eh2077

App/src/pages/iou/MoneyRequestAmountForm.tsx

Line 260 in e6b5552

autoGrowExtraSpace={variables.w80}

Other places are using it without a specific platform. I think we should keep it consistent, and I tested it on the web. When we add autoGrowExtraSpace={variables.w80} no issues occur. What do you think?

If you still want specific for native, then we update to:

autoGrowExtraSpace={getPlatform() === CONST.PLATFORM.ANDROID || getPlatform() === CONST.PLATFORM.IOS ? variables.w80 : undefined}

eh2077 · 2025-03-20T23:35:49Z

The original issue was reported on android app, so I think you should test it on native platforms

huult · 2025-03-21T00:03:38Z

@eh2077 I also tested on the native platform. Ah, sorry, I'm wrong. I added the recording for native. Thanks.

eh2077 · 2025-03-25T05:45:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-16.at.6.48.00.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-03-16.at.6.54.12.PM.mov

iOS: Native

Screen.Recording.2025-03-16.at.6.48.56.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-03-16.at.6.53.28.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-16.at.6.52.39.PM.mov

MacOS: Desktop

Screen.Recording.2025-03-16.at.7.35.06.PM.mov

eh2077 · 2025-03-25T06:48:22Z

@huult Can you also do some testings on other pages (mainly on Native Apps) that also use the AmountForm?

huult · 2025-03-25T06:53:04Z

@eh2077

App/src/pages/workspace/taxes/WorkspaceCreateTaxPage.tsx

Line 104 in 1408a2d

InputComponent={AmountPicker}

It seems AmountForm is only used by AmountPicker as InputComponent inside WorkspaceCreateTaxPage. Do you know of any other cases?

eh2077 · 2025-03-25T13:50:23Z

@huult No, it's used by many pages, see

huult · 2025-03-27T15:29:07Z

@eh2077 I will update it soon. thanks

huult · 2025-03-28T01:57:14Z

@eh2077 I tested and it's working well

…-move

eh2077

LGTM

OSBotify · 2025-03-31T08:43:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-31T10:42:20Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.1.21-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-01T15:01:23Z

🚀 Deployed to production by https://github.com/grgia in version: 9.1.21-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

huult added 2 commits March 13, 2025 21:12

add autoGrowExtraSpace for AmountForm

0132a9d

Merge remote-tracking branch 'upstream/main' into 56951-tax-input-dot…

196c230

…-move

huult requested a review from a team as a code owner March 13, 2025 15:02

melvin-bot bot requested review from eh2077 and removed request for a team March 13, 2025 15:02

fix lint

a26ed07

eh2077 reviewed Mar 16, 2025

View reviewed changes

src/components/AmountForm.tsx Show resolved Hide resolved

Merge remote-tracking branch 'upstream/main' into 56951-tax-input-dot…

8aa3040

…-move

eh2077 approved these changes Mar 28, 2025

View reviewed changes

melvin-bot bot requested a review from lakchote March 28, 2025 13:35

lakchote approved these changes Mar 31, 2025

View reviewed changes

lakchote merged commit 9eb1310 into Expensify:main Mar 31, 2025
17 checks passed

github-actions bot mentioned this pull request Mar 31, 2025

Deploy Checklist: New Expensify 2025-03-31 #59334

Closed

62 tasks

melvin-bot bot mentioned this pull request Apr 1, 2025

[Due for payment 2025-04-08] [$250] Tax - After a digit, entering dot moves the first digit while adding tax rate #56951

Closed

8 tasks

linhvovan29546 mentioned this pull request Apr 6, 2025

[Due for payment 2025-05-28] [$250] Android - When entering tax rate, digit overlap with percentage symbol #59607

Open

8 tasks

56951 tax input dot move #58380

56951 tax input dot move #58380

Uh oh!

Conversation

huult commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 13, 2025

Uh oh!

Uh oh!

eh2077 commented Mar 16, 2025

Uh oh!

eh2077 commented Mar 20, 2025

Uh oh!

huult commented Mar 20, 2025

Uh oh!

huult commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eh2077 commented Mar 20, 2025

Uh oh!

huult commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eh2077 commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eh2077 commented Mar 25, 2025

Uh oh!

huult commented Mar 25, 2025

Uh oh!

eh2077 commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

huult commented Mar 27, 2025

Uh oh!

huult commented Mar 28, 2025

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 31, 2025

Uh oh!

github-actions bot commented Mar 31, 2025

Uh oh!

github-actions bot commented Apr 1, 2025

Uh oh!

Uh oh!

huult commented Mar 13, 2025 •

edited

Loading

huult commented Mar 20, 2025 •

edited

Loading

huult commented Mar 21, 2025 •

edited

Loading

eh2077 commented Mar 25, 2025 •

edited

Loading

eh2077 commented Mar 25, 2025 •

edited

Loading