[Due for payment 2025-04-25] [$250] Blank RHP displayed

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.21-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Create a new workspace
2. Go to route settings/workspaces/{policyID}/categories/imported
3. Observe the RHP

Expected Result:

Page not found is displayed

Actual Result:

Blank RHP screen is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

bug.1.mov

Recording.1096.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021906709520063749780
• Upwork Job ID: 1906709520063749780
• Last Price Increase: 2025-03-31

Issue Owner

Current Issue Owner: @rayane-d

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

Proposal by @dukenv0307

Proposal

Please re-state the problem that we are trying to solve in this issue.

Blank screen is displayed

What is the root cause of that problem?

When we don't have spreadsheetColumns we return undefined

App/src/pages/workspace/categories/ImportedCategoriesPage.tsx

Lines 123 to 126 in 9eb1310

	const spreadsheetColumns = spreadsheet?.data;
	if (!spreadsheetColumns) {
	return;
	}

What changes do you think we should make in order to solve the problem?

Show the not found page when we don't have spreadsheet

    const [spreadsheet, spreadsheetMetadata] = useOnyx(ONYXKEYS.IMPORTED_SPREADSHEET);
    ...
    if (hasAccountingConnections || (!spreadsheet && !isLoadingOnyxValue(spreadsheetMetadata))) {
        return <NotFoundPage />;
    }

We need to check the condition isLoadingOnyxValue(spreadsheetMetadata) to ensure that the not found page doesn't briefly appear at the beginning.

Note: We can check other import locations to see if having this problem.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

We can show the loading page when isLoadingOnyxValue(spreadsheetMetadata) is true

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021906709520063749780

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-d (External)

[grgia]

@dukenv0307 can you push a PR today?

[dukenv0307]

@grgia yes

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.29-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Category Import] fix - Blank RHP imported page displayed #59395

If no regressions arise, payment will be issued on 2025-04-25. 🎊

For reference, here are some details about the assignees on this issue:

• @rayane-d requires payment through NewDot Manual Requests
• @dukenv0307 requires payment through NewDot Manual Requests

[melvin-bot]

@rayane-d / @dukenv0307 @garrettmknight @rayane-d / @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[garrettmknight]

Payment Summary

• Contributor: @dukenv0307 $250 via NewDot
• Contributor+: @rayane-d $250 via NewDot

[rayane-d]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Add CSV import flow to Categories page #47827 (comment)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• Create a new workspace

Test:

1. Go to Settings > Workspaces
2. Select the workspace
3. Copy the ID of the workspace from the URL
4. Add /categories/imported to the copied URL
5. Visit the URL
6. Verify that a not foud page is displayed instead of a blank page
7. Go to workspace settings
8. Go to member (or Per diem, Tags)
9. Click 3-dot menu > Import spreadsheet.
10. Click Upload.
11. Select a file.
12. Map the columns and click Import.
13. Click on "Got it".
14. Verify that the side panel is closed properly without briefly displaying a not found page.

Do we agree 👍 or 👎

[JmillsExpensify]

Payment Summary

• Contributor: @dukenv0307 $250 via NewDot
• Contributor+: @rayane-d $250 via NewDot

[melvin-bot]

@rayane-d Whoops! This issue is 2 days overdue. Let's get this updated quick!

[garrettmknight]

@rayane-d request when you're ready.

[garrettmknight]

Payment Summary

• Contributor: @dukenv0307 $250 via NewDot
• Contributor+: @rayane-d $250 via NewDot

[JmillsExpensify]

$250 approved for @dukenv0307

[garrettmknight]

$250 approved for @rayane-d