Import - Importing Member, Tags and Per diem cause not here page on LHP after clicking Got it

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.29-3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #59647
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Web, mweb
App Component: Workspace Settings

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Create a workspace
3. Go to member (or Per diem, Tags)
4. Click 3-dot menu > Import spreadsheet.
5. Click Upload.
6. Select a file.
7. Map the columns and click Import.
8. Click Got it.

Expected Result:

No not here page should appear in LHP

Actual Result:

when importing category, Tags, and Per diem not here page appears on LHP after clicking Got it.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6804650_1744867353857.bandicam_2025-04-17_08-21-19-058.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

when importing category, Tags, and Per diem not here page appears on LHP after clicking Got it.

What is the root cause of that problem?

This comes from #59395

In perdiem page:

When closing imported modal, we call

App/src/pages/workspace/perDiem/ImportedPerDiemPage.tsx

Line 142 in 96c2585

closeImportPage();

closeImportPage will remove contents in ONYXKEYS.IMPORTED_SPREADSHEET, which will cause the page to return not found page

App/src/pages/workspace/perDiem/ImportedPerDiemPage.tsx

Lines 135 to 138 in 96c2585

	const spreadsheetColumns = spreadsheet?.data;
	if (!spreadsheetColumns) {
	return <NotFoundPage />;
	}

What changes do you think we should make in order to solve the problem?

In the offending PR, they fixed this bug only on Imported category page, commit here. We should apply same fix to other pages as well.

Or more simple solution, we should call closeImportPage on page unmount only

    useEffect(
        () => () => {
            closeImportPage();
        },
        [],
    );

Same as other pages

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[mjasikowski]

Demoting since it's just a visual bug

[daledah]

I can help raise a quick PR if needed.

[dukenv0307]

Opened the PR to fix this issue. cc @mjasikowski @rayane-d

[melvin-bot]

@mjasikowski @johncschuster @rayane-d @dukenv0307 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[rayane-d]

PR was deployed to production #60419 (comment)