[Due for payment 2025-04-16] [$250] Report headers show You for resolve duplicate system message

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.21-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #58575
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: MacOS Chrome, Desktop
App Component: Money Requests

Action Performed:

1. Create 2 money requests in WC chat with the same amount
2. Verify they get a duplicate violation
3. Open one of them > Review Duplicates > Keep this one
4. Right click on resolved the duplicate system message > reply in thread

Expected Result:

Report header should show 'resolved the duplicate'

Actual Result:

Report header shows You

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6787874_1743422121836.Screen_Recording_2025-03-31_at_2.47.55_in_the_afternoon.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021906706648056613634
• Upwork Job ID: 1906706648056613634
• Last Price Increase: 2025-03-31
• Automatic offers:
• daledah | Contributor | 106731312

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report header shows You

What is the root cause of that problem?

Comming from this PR: #58575

We forgot to add case CONST.REPORT.ACTIONS.TYPE.RESOLVED_DUPLICATES to function getReportNameInternal

What changes do you think we should make in order to solve the problem?

We should add this case

        if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.RESOLVED_DUPLICATES) {
            return translateLocal('violations.resolvedDuplicates');
        }

App/src/libs/ReportUtils.ts

Line 4589 in 1c74508

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[getusha]

I think we can demote this given it was a new feature and the issue is minor

[rlinoz]

Agreed

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021906706648056613634

[melvin-bot]

Current assignee @getusha is eligible for the External assigner, not assigning anyone new.

[daledah]

I'll raise PR soon

[melvin-bot]

📣 @daledah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[daledah]

@getusha we have a pr here

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.24-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: headers show You for resolve duplicate system #59365

If no regressions arise, payment will be issued on 2025-04-16. 🎊

For reference, here are some details about the assignees on this issue:

• @getusha requires payment through NewDot Manual Requests
• @daledah requires payment automatic offer (Contributor)

[melvin-bot]

@getusha @dylanexpensify @getusha The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[rlinoz]

@dylanexpensify this is a bug from a previous PR, so I think @getusha doesn't require a payment here, correct me if I am wrong.

[dylanexpensify]

Nice, agree

[melvin-bot]

@dylanexpensify Eep! 4 days overdue now. Issues have feelings too...

[dylanexpensify]

@daledah paid!