Hide the REIMBURSED action type #59192

deetergp · 2025-03-26T21:23:06Z

Explanation of Change

This PR updates PureReportActionItem.renderReportActionItem so that it returns null when attempting to render REIMBURSED report actions. That action type is meant for OldDot only and all the information it displays is already show by other actions.

Fixed Issues

$ #54289
PROPOSAL: N/A

Tests

Have a workspace with a Approvals, a valid or test payment card, a workspace admin and a submitter.
As the submitter, submit an expense to your workspace chat
As the approver, approve the submitted expense, which should automatically generate a payment
As both users, in the expense report chat, verify that you see a message that the workspace admin approved the expense, and one saying that the amount was automatically paid.
Verify that no message mentioning Concierge paying the amount is displayed.

Before

After

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-03-26T21:23:11Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-03-26T21:23:19Z

@ishpaul777 @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins

LGTM. @ishpaul777 all yours

ishpaul777 · 2025-03-27T20:41:10Z

src/pages/home/report/PureReportActionItem.tsx

+    // information they display is already provided by other actions.
+    if (action.actionName === CONST.REPORT.ACTIONS.TYPE.REIMBURSED) {
+        return null;
+    }


I think the preffered way should be to not have this action to be visible, we have shouldReportActionBeVisible in src/libs/ReportActionsUtils.ts can we return false on that function?

Good call @ishpaul777! There is a list of deprecated OldDot actions in there and this is one of those, so I added it to the list.

This reverts commit f57b076.

deetergp · 2025-03-27T22:17:25Z

Updated!

ishpaul777 · 2025-03-27T22:33:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2025-03-28.at.4.12.57.AM.mov

iOS: Native

Screen.Recording.2025-03-28.at.4.46.29.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-03-28.at.4.08.35.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-28.at.12.32.49.AM.mov

MacOS: Desktop

Screen.Recording.2025-03-28.at.4.23.47.AM.mov

melvin-bot · 2025-03-27T23:02:43Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2025-03-27T23:15:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-31T10:43:34Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.21-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-01T15:02:26Z

🚀 Deployed to production by https://github.com/grgia in version: 9.1.21-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Hide the REIMBURSED action type

f57b076

deetergp self-assigned this Mar 26, 2025

deetergp requested a review from a team as a code owner March 26, 2025 21:23

melvin-bot bot requested a review from dominictb March 26, 2025 21:23

melvin-bot bot removed the request for review from a team March 26, 2025 21:23

deetergp requested review from luacmartins and a team and removed request for dominictb March 26, 2025 21:23

melvin-bot bot requested review from ishpaul777 and removed request for a team March 26, 2025 21:23

deetergp removed the request for review from ishpaul777 March 26, 2025 22:15

luacmartins requested a review from ishpaul777 March 27, 2025 20:37

luacmartins previously approved these changes Mar 27, 2025

View reviewed changes

ishpaul777 reviewed Mar 27, 2025

View reviewed changes

deetergp added 3 commits March 27, 2025 15:06

Merge branch 'main' into scott-hideReimbursedAction

0c3e671

Add REIMBURSED to the list of deprecated OldDot actions

0178ce8

Revert "Hide the REIMBURSED action type"

5b83820

This reverts commit f57b076.

deetergp dismissed luacmartins’s stale review via 5b83820 March 27, 2025 22:16

ishpaul777 approved these changes Mar 27, 2025

View reviewed changes

melvin-bot bot requested a review from mollfpr March 27, 2025 23:02

luacmartins removed the request for review from mollfpr March 27, 2025 23:07

luacmartins approved these changes Mar 27, 2025

View reviewed changes

luacmartins merged commit 6109957 into main Mar 27, 2025
17 of 19 checks passed

luacmartins deleted the scott-hideReimbursedAction branch March 27, 2025 23:07

github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Mar 28, 2025

This was referenced Mar 28, 2025

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #59266

Closed

Deploy Checklist: New Expensify 2025-03-31 #59334

Closed

ishpaul777 mentioned this pull request Mar 31, 2025

[Due for payment 2025-04-08] [HIGH] Duplicate system messages appear for the same action during reimbursement approval #54289

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Hide the REIMBURSED action type #59192

Hide the REIMBURSED action type #59192

Uh oh!

deetergp commented Mar 26, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Mar 26, 2025

Uh oh!

melvin-bot bot commented Mar 26, 2025

Uh oh!

luacmartins left a comment

Uh oh!

ishpaul777 Mar 27, 2025

Uh oh!

deetergp Mar 27, 2025

Uh oh!

deetergp commented Mar 27, 2025

Uh oh!

ishpaul777 commented Mar 27, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Mar 27, 2025

Uh oh!

Uh oh!

OSBotify commented Mar 27, 2025

Uh oh!

github-actions bot commented Mar 31, 2025

Uh oh!

github-actions bot commented Apr 1, 2025

Uh oh!

Uh oh!

Hide the REIMBURSED action type #59192

Hide the REIMBURSED action type #59192

Uh oh!

Conversation

deetergp commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Before

After

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 26, 2025

Uh oh!

melvin-bot bot commented Mar 26, 2025

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

ishpaul777 Mar 27, 2025

Choose a reason for hiding this comment

Uh oh!

deetergp Mar 27, 2025

Choose a reason for hiding this comment

Uh oh!

deetergp commented Mar 27, 2025

Uh oh!

ishpaul777 commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 27, 2025

Uh oh!

Uh oh!

OSBotify commented Mar 27, 2025

Uh oh!

github-actions bot commented Mar 31, 2025

Uh oh!

github-actions bot commented Apr 1, 2025

Uh oh!

Uh oh!

deetergp commented Mar 26, 2025 •

edited

Loading

ishpaul777 commented Mar 27, 2025 •

edited

Loading