fix: always offset bottom safe area padding for `OfflineIndicator` #59144

chrispader · 2025-03-26T11:09:08Z

@mountiny @nlemma @slafortune @Ollyws

Explanation of Change

Fixes issues caused by the changes to the OfflineIndicator in the ScreenWrapper in #58909

Fixed Issues

$ #58820
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Launch app
Go to workspace settings - overview
Turn off the internet / Enable "Force offline" in Debug menu
Tap default currency
Tap text input to open keyboard
Make sure the offline indicator does not have extra padding between the keyboard

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Same as in Tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Screen_Recording_20250326_131642_New.Expensify.Dev.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-03-26T11:09:13Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-03-26T23:06:58Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

mountiny

Kicked off the build and changes look good to me @dominictb could you prioritize this review please?

github-actions · 2025-03-26T23:48:22Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed
Android Hybrid 🤖🔄	iOS Hybrid 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/59144-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/59144-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/59144/NewExpensify.dmg	https://59144.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dominictb · 2025-03-27T11:29:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

dominictb

chrispader · 2025-03-27T18:08:59Z

@dominictb @mountiny last commit is just removing a variable and placing it inline in KeyboardAvoidingView as it's easier to read and understand within the context of the component.

This does not change functionality.

mountiny · 2025-03-27T18:37:24Z

Thanks

OSBotify · 2025-03-27T18:46:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-31T10:43:10Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.21-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-01T15:02:02Z

🚀 Deployed to production by https://github.com/grgia in version: 9.1.21-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

fix: always offset bottom safe area padding

33bd023

chrispader requested a review from a team as a code owner March 26, 2025 11:09

melvin-bot bot requested a review from dominictb March 26, 2025 11:09

melvin-bot bot removed the request for review from a team March 26, 2025 11:09

This was referenced Mar 26, 2025

[Due for payment 2025-04-17] [$250] iOS mWeb - Workspace - Offline indicator isn't sticking to the keyboard #59135

Closed

fix: Add keyboard offset if offline indicator is visible #58909

Merged

mountiny assigned chrispader Mar 26, 2025

mountiny self-requested a review March 26, 2025 23:06

mountiny previously approved these changes Mar 26, 2025

View reviewed changes

dominictb approved these changes Mar 27, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny March 27, 2025 12:06

remove unnecessary variable

fdb9f17

chrispader dismissed mountiny’s stale review via fdb9f17 March 27, 2025 18:08

mountiny approved these changes Mar 27, 2025

View reviewed changes

mountiny merged commit 83b6d16 into Expensify:main Mar 27, 2025
17 checks passed

github-actions bot mentioned this pull request Mar 31, 2025

Deploy Checklist: New Expensify 2025-03-31 #59334

Closed

62 tasks

melvin-bot bot mentioned this pull request Apr 1, 2025

[Due for payment 2025-04-08] [Discussion] Workspace - In"Default currency" page, extra white space below "you appears to offline #58820

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: always offset bottom safe area padding for `OfflineIndicator` #59144

fix: always offset bottom safe area padding for `OfflineIndicator` #59144

Uh oh!

chrispader commented Mar 26, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Mar 26, 2025

Uh oh!

github-actions bot commented Mar 26, 2025

Uh oh!

mountiny left a comment

Uh oh!

github-actions bot commented Mar 26, 2025

Uh oh!

dominictb commented Mar 27, 2025 •

edited

Loading

Uh oh!

dominictb left a comment

Uh oh!

chrispader commented Mar 27, 2025

Uh oh!

mountiny commented Mar 27, 2025

Uh oh!

Uh oh!

OSBotify commented Mar 27, 2025

Uh oh!

github-actions bot commented Mar 31, 2025

Uh oh!

github-actions bot commented Apr 1, 2025

Uh oh!

Uh oh!

fix: always offset bottom safe area padding for OfflineIndicator #59144

fix: always offset bottom safe area padding for OfflineIndicator #59144

Uh oh!

Conversation

chrispader commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 26, 2025

Uh oh!

github-actions bot commented Mar 26, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 26, 2025

Uh oh!

dominictb commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dominictb left a comment

Choose a reason for hiding this comment

Uh oh!

chrispader commented Mar 27, 2025

Uh oh!

mountiny commented Mar 27, 2025

Uh oh!

Uh oh!

OSBotify commented Mar 27, 2025

Uh oh!

github-actions bot commented Mar 31, 2025

Uh oh!

github-actions bot commented Apr 1, 2025

Uh oh!

Uh oh!

fix: always offset bottom safe area padding for `OfflineIndicator` #59144

fix: always offset bottom safe area padding for `OfflineIndicator` #59144

chrispader commented Mar 26, 2025 •

edited

Loading

dominictb commented Mar 27, 2025 •

edited

Loading