[Due for payment 2025-04-16] [Report Creation UI] Create report button opens empty workspace selection page when there is no workspace

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.21-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Other

Action Performed:

Precondition:

• Log in with Expensifail account.
• Account has no workspace.

1. Go to staging.new.expensify.com
2. Open FAB.
3. Click Create report.

Expected Result:

App will show "Coming soon" modal with Switch to Expensify Classic option.

Actual Result:

App opens empty workspace selection page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6787844_1743418835897.Screen_Recording_2025-03-31_at_18.38.29.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Create report button opens empty workspace selection page when there is no workspace

What is the root cause of that problem?

• We return false when groupPolicies.length === 0 is true but that's wrong because in that case we should be returning true.
  

  App/src/libs/PolicyUtils.ts

  Lines 1260 to 1266 in b5807fa

  	function areAllGroupPoliciesExpenseChatDisabled(policies = allPolicies) {
  	const groupPolicies = Object.values(policies ?? {}).filter((policy) => isPaidGroupPolicy(policy));
  	if (groupPolicies.length === 0) {
  	return false;
  	}
  	return !groupPolicies.some((policy) => !!policy?.isPolicyExpenseChatEnabled);
  	}

What changes do you think we should make in order to solve the problem?

• Update the function to:

function areAllGroupPoliciesExpenseChatDisabled(policies = allPolicies) {
    const groupPolicies = Object.values(policies ?? {}).filter((policy) => isPaidGroupPolicy(policy));
    if (groupPolicies.length === 0) {
        return true;
    }
    return !groupPolicies.some((policy) => !!policy?.isPolicyExpenseChatEnabled);
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• We can create a test for areAllGroupPoliciesExpenseChatDisabled and pass dummy policies with different values.

What alternative solutions did you explore? (Optional)

NA

Result

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[SzymczakJ]

This is part of Crate Report follow-ups issue, we will solve this issue in it. Therefore this issue can be closed in favor of that issue cc @mountiny @luacmartins .

[melvin-bot]

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

I added 2 blocker labels, because some testers can repro this issue with staging server off, some - not.

[mountiny]

@SzymczakJ Since its already opened, lets keep it for easier tracking

[sakluger]

@mountiny what's the deal with this one? It looks like you have already assigned folks to work on it, I'm guessing we don't need contributor proposals, right?

[trjExpensify]

Fix is coming here: #59386

[allgandalf]

please assign @DylanDylann here and remove my assignment, they are reviewing the PR

[allgandalf]

taking it back againnnn

[mountiny]

PR closed, we will handle the QA on the PR with Applause, no payments or regression tests required so closing

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.24-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Create report flow follow ups #59386

If no regressions arise, payment will be issued on 2025-04-16. 🎊

For reference, here are some details about the assignees on this issue:

• @SzymczakJ does not require payment (Contractor)
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

@allgandalf @sakluger @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]