[Due for payment 2025-04-23] [Due for payment 2025-04-16] [Report Creation UI] Follow up tasks

[mountiny]

There is could of follow up tasks to handle after this PR is merged that we are aware off #58795

• There is option to Create Report in FAB when no workspaces are present Create report flow follow ups #59386
• No create report option in workspace chat Create report flow follow ups #59386
• New expenses added from the report view page doesn't get updated in the table of the report view.
• No option to add expense if report is created offline Create report flow follow ups #59386
• Expense tab is highlighted when report is opened in the search page - taken care of in another PR.
• Add test for NextStepsUtils to cover the empty report case Create report flow follow ups #59386
• Assert in the test for QAB that correct chatReportID was added by optimistic action @SzymczakJ

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[SzymczakJ]

I found bugs that I haven't seen reported before, I'll post it here for. visibility and so that I remember to fix them along with this issue:

1. Optimistic report preview has wrong avatar and missing currency:

Screen.Recording.2025-03-31.at.18.51.30.mov

2. We are missing OfflineWithFeedback blur/failure state on SearchMoneyRequestReportPage when creating report while offline:

Screen.Recording.2025-03-31.at.19.47.48.mov

Design:

[melvin-bot]

@sumo-slonik Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[SzymczakJ]

WIP I'll give it out for review soon.

[trjExpensify]

Melv, go away. Jakub has a draft PR up: #59386

[allgandalf]

Please assign @DylanDylann here, they are reviewing the PR

[allgandalf]

ended up taking it back again, @mountiny again pleaseee 😸

[mountiny]

@SzymczakJ I believe all of the points were addressed in #59386 but just wanted to check in that is the case with you too and then we can close this one

[SzymczakJ]

I believe @allgandalf found a way to repro "No option to add expense if report is created offline", which I wasn't able to reproduce, so that's the only issue not resolved.
But as we stated in #59386 (review) we will fix these things in another follow up, so if there's one we can move "No option to add expense if report is created offline" to it.

[mountiny]

@SzymczakJ Lets just use this issue for that, once you have a PR for it or if we can export this with reproduction steps, just let me know

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.24-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Create report flow follow ups #59386

If no regressions arise, payment will be issued on 2025-04-16. 🎊

For reference, here are some details about the assignees on this issue:

• @sumo-slonik does not require payment (Contractor)
• @SzymczakJ does not require payment (Contractor)
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

@allgandalf @trjExpensify @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[SzymczakJ]

I fixed No option to add expense if report is created offline and added this fix to #59735.

[mountiny]

All points should be fixed so we can close now, thanks 🎉

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.28-15-staging and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Make SearchMoneyRequestReportPage show single transaction view correctly #59735

If no regressions arise, payment will be issued on 2025-04-23. 🎊

For reference, here are some details about the assignees on this issue:

• @sumo-slonik does not require payment (Contractor)
• @SzymczakJ does not require payment (Contractor)
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

@allgandalf @trjExpensify @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]