Skip to content

[Due for payment 2025-04-16] [Report Creation UI] QAB - Workspace name under "Create expense" does not update after changing display name #59425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
8 tasks done
IuliiaHerets opened this issue Apr 1, 2025 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Apr 1, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.21-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Other

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new account.
  3. Create a workspace.
  4. Go to workspace chat.
  5. Submit a manual expense.
  6. Go to Settings > Profile > Display name.
  7. Edit the display name and save it.
  8. Click FAB button.

Expected Result:

Quick action will show the new workspace chat name under "Create expense".

Actual Result:

Quick action still shows the old workspace chat name under "Create expense".
It only displays the new name after refreshing the page.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image https://github.com/user-attachments/assets/58cdc7cf-ea2f-42ad-af5e-9db00b142bb4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @miljakljajic
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Apr 1, 2025
Copy link

melvin-bot bot commented Apr 1, 2025

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 1, 2025

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Apr 1, 2025
Copy link

melvin-bot bot commented Apr 1, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 1, 2025
Copy link
Contributor

github-actions bot commented Apr 1, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 1, 2025
@mountiny
Copy link
Contributor

mountiny commented Apr 1, 2025

Does not need to be a blocker, but it might come from the QAB changes @SzymczakJ

@SzymczakJ
Copy link
Contributor

I'll take a look at it today ✋

@SzymczakJ
Copy link
Contributor

I've found a fix for that, I'll fix it in #59295 as it is a follow up issue.

@flaviadefaria flaviadefaria moved this to Second Cohort - CRITICAL in [#whatsnext] #migrate Apr 1, 2025
@trjExpensify trjExpensify changed the title QAB - Workspace name under "Create expense" does not update after changing display name [Report Creation UI] QAB - Workspace name under "Create expense" does not update after changing display name Apr 2, 2025
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 3, 2025
@mountiny
Copy link
Contributor

mountiny commented Apr 5, 2025

PR closed, we will handle the QA on the PR with Applause, no payments or regression tests required so closing

@mountiny mountiny closed this as completed Apr 5, 2025
@github-project-automation github-project-automation bot moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrate Apr 5, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 9, 2025
@melvin-bot melvin-bot bot changed the title [Report Creation UI] QAB - Workspace name under "Create expense" does not update after changing display name [Due for payment 2025-04-16] [Report Creation UI] QAB - Workspace name under "Create expense" does not update after changing display name Apr 9, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 9, 2025
Copy link

melvin-bot bot commented Apr 9, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Apr 9, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.24-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-16. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Apr 9, 2025

@DylanDylann @miljakljajic @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
Development

No branches or pull requests

5 participants