-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Return early when caching sound #59188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚧 @mountiny has triggered a test app build. You can view the workflow run here. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
@jayeshmangwani @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@jayeshmangwani are you able to review and test this pr please? |
@mountiny Sorry, I thought this PR didn’t need a C+ review. I can review it tomorrow morning (in about 10 hours). If it needs to be merged urgently, feel free to reassign it. |
np |
@mountiny I’ve been following the Tests steps on the staging version, but I’m not encountering any crashes after signing in with another account on the web and opening it on Desktop. I’m not sure how to confirm if this change will resolve Ryan’s crash issue. |
Right the crash was fixed by AuthScreens refactor revert, but this console log line was relevant to this change so I would test that:
|
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / Safariweb-sound.movMacOS: Desktopdesktop-sound.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.1.21-0 🚀
|
🚀 Deployed to production by https://github.com/grgia in version: 9.1.21-3 🚀
|
Explanation of Change
The cache APi does not work with files with
app
scheme and the app is stuck with this errorWe should not need to cache the sounds for the electron app as we can access them easily there
Fixed Issues
$ #59184
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Screen.Recording.2025-03-26.at.22.10.30.mp4
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop