Skip to content

fix: always run onTestFinished in reverse order #5598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Apr 23, 2024

Description

Fixes #5529

TODO:

  • Test

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit a22f2cc
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/6627bb9f26e937000896ede3

@sheremet-va sheremet-va merged commit 23f29ce into vitest-dev:main Apr 23, 2024
18 of 19 checks passed
@sheremet-va sheremet-va deleted the fix/order-ontestfinished branch April 23, 2024 14:45
@nvie
Copy link

nvie commented Apr 23, 2024

Lovely, thanks @sheremet-va 🙏 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Execute onTestFinished handlers in the reverse order they are scheduled in
2 participants