Skip to content

fix(browser): dispose tester iframe on done #5595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

hi-ogawa
Copy link
Contributor

Description

Currently iframes are not disposed and that seems to make browser mode get stuck.
We might not want to always dispose the iframe, for example, if users are expecting to view the actual browser render (cf. #5568), but I think that can be implemented as a dedicated option (like browser.retainWindow or something) and disposing them by default for stability seems right.

Test plan

I tested a same patch on https://github.com/underoot/vitest-large-file-list-issue with 300 test files and it's working fine at least with fileParallelism: false:

image

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit b5dd8d1
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/6627759f277157000849413e

@hi-ogawa hi-ogawa marked this pull request as ready for review April 23, 2024 09:03
@sheremet-va sheremet-va merged commit b213571 into vitest-dev:main Apr 23, 2024
18 of 19 checks passed
@hi-ogawa hi-ogawa deleted the fix-browser-dispose-iframe branch April 23, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser mode fails with SyntaxError: Failed to construct 'WebSocket'
2 participants