-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(vm): support network imports #5610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vm): support network imports #5610
Conversation
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up.
I wasn't sure if we should enable code execution from network by default.
I'm not really familiar with what people consider secure or insecure, but I think NodeJs and Deno requires explicit flags to enable this, so I was a bit scared of this.
Also a few more limitations on NodeJS are written here https://nodejs.org/api/esm.html#https-and-http-imports, for example, they only support "https" and also they probably don't allow import "file:..."
in network modules.
What's your thought?
Also just cross-linking my old PR #4996
I think we should follow the limitations of Node here. I will update the PR |
ba6ba07
to
2bbf569
Compare
Description
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.