fix: call resolveId('vitest') after buildStart
#5646
Conversation
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hi-ogawa
changed the title
require.resolve('vitest') instead of resolveId during initresolveId('vitest') after buildStart
packages/vitest/src/node/core.ts
Outdated
| @@ -386,6 +381,11 @@ export class Vitest { | |||
| async start(filters?: string[]) { | |||
| this._onClose = [] | |||
|
|
|||
| // if Vitest is running globally, then we should still import local vitest if possible | |||
| const projectVitestPath = await this.vitenode.resolveId('vitest') | |||
| const vitestDir = projectVitestPath ? resolve(projectVitestPath.id, '../..') : rootDir | |||
There was a problem hiding this comment.
vs code extension doesn't call start at all
There was a problem hiding this comment.
Oh, really...
I had createRequire approach before 1037511. Would this work better?
There was a problem hiding this comment.
Or we could delay it further to ctx.runFiles. Let me think...
There was a problem hiding this comment.
The createRequire approach is wrong because we need Vite to process it. Having it in runFiles is fine. We can have a guard to not check this path if it is resolved, and reset it in configureServer
There was a problem hiding this comment.
Do we need Vite's resolution? If the purpose is only to find local Vitest, would createRequire with require.resolve('vitest', { paths: [config.root] }) do the same?
This was the approach used for package installer:
vitest/packages/vitest/src/node/packageInstaller.ts
Lines 15 to 18 in 04df286
There was a problem hiding this comment.
We need Vite's resolution because files importing vitest are processed by Vite. It's possible that Vitest is called globally and resolved id is not correct, or there is an alias or resolveId interception
Description
resolveIdis called beforebuildStartwith enforce: 'pre' #5616ctx.distPathis only used by poolrunTests, so we can moveresolveIdfromctx.setServertoctx.start.todo
pnpm.overridesPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.