Skip to content

fix: fix default import.meta.env.PROD: false #5561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Apr 18, 2024

Description

setupEnv added in #5476 was assigning boolean values from config.env to process.env (such as config.env.PROD: false). I fixed it by copying the same PROD/DEV specific logic from VitestPlugin.configResolved:

// we replace every "import.meta.env" with "process.env"
// to allow reassigning, so we need to put all envs on process.env
const { PROD, DEV, ...envs } = viteConfig.env
// process.env can have only string values and will cast string on it if we pass other type,
// so we are making them truthy
process.env.PROD ??= PROD ? '1' : ''
process.env.DEV ??= DEV ? '1' : ''
for (const name in envs)
process.env[name] ??= envs[name]

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit d7a0da9
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/66209e1811454400080370fe

@hi-ogawa hi-ogawa marked this pull request as ready for review April 18, 2024 05:01
@hi-ogawa hi-ogawa changed the title fix: fix default import.meta.env.PROD = false fix: fix default import.meta.env.PROD: false Apr 19, 2024
@sheremet-va sheremet-va merged commit 9c64967 into vitest-dev:main Apr 22, 2024
18 of 19 checks passed
@hi-ogawa hi-ogawa deleted the fix-import-meta-env-prod branch April 22, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants