Skip to content

fix(vitest): fix false positive file filter match with leading slash #5578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Apr 21, 2024

Description

With the current filter condition, it makes false positive in a following way

dir: /home/hiroshi/code/others/vitest/examples/basic
filter: /basic                             // looks like absolute path but users wish to use to match substring
relativePath = ../../../../../../../basic  // starts with '../..' so filter is true regardless of `testFile`

I'm not sure supporting a filter like /basic has been planned, but I OP's usage makes sense to me.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Apr 21, 2024

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit be3a1f1
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/6625abcc607b940008a92ec5

@hi-ogawa hi-ogawa marked this pull request as ready for review April 22, 2024 00:14
@sheremet-va sheremet-va merged commit 316eb73 into vitest-dev:main Apr 22, 2024
19 checks passed
@hi-ogawa hi-ogawa deleted the fix-false-positive-absolute-path-file-filter branch April 22, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v.1.5.0 can't pass filters with leading/trailing slashes to CLI
2 participants