Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

Self-nomination for Maintainer role #5281

Closed
wants to merge 1 commit into from

Conversation

mudit-01
Copy link
Contributor

@mudit-01 mudit-01 commented Feb 3, 2023

Hi Maintainers
I've been contributing to OSM for a year now. CLI, documentation, and other areas are where I have contributed. I accept each and every prerequisite for becoming a Maintainer. Hence self-nominating myself for the role of a Maintainer. Thanks!

Signed-off-by: mudit singh [email protected]

Description:

Testing done: NA

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [x ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?

  3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

Hi Maintainers
I've been contributing to OSM for a year now. CLI, documentation, and other areas are where I have contributed. I accept each and every prerequisite for becoming a Maintainer. Hence self-nominating myself for the role of a Maintainer.
Thanks!

Signed-off-by: mudit singh <[email protected]>
@mudit-01 mudit-01 marked this pull request as ready for review February 3, 2023 05:28
Copy link
Contributor

@keithmattix keithmattix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all of your contributions to the project!

Copy link
Contributor

@trstringer trstringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thank you for everything!

@mudit-01
Copy link
Contributor Author

mudit-01 commented Feb 6, 2023

Thanks! @keithmattix and @trstringer. 🙂
Can we merge this PR?

@trstringer
Copy link
Contributor

We need to wait for a majority vote prior to merging!

// @nojnhuh @jaellio @shalier @steeling

@mudit-01
Copy link
Contributor Author

@nojnhuh @jaellio @shalier @steeling waiting for your vote PTAL

@jaellio
Copy link
Contributor

jaellio commented Feb 24, 2023

@mudit-01 Could you please provide 10 PR's that you believe demonstrate expertise across the OSM codebase? Thanks!

@mudit-01
Copy link
Contributor Author

mudit-01 commented Feb 25, 2023

Hi @jaellio below are requested PRs that I have been contributing in OSM in the area of CLI and doc:
#5266
#5094
#5021
#4792
#4738
#4555
#4549
#4539
#4463
#4473
#4348
#4322
#4004

@mudit-01
Copy link
Contributor Author

@jaellio waiting for your views on this PR. Thanks!

@mudit-01
Copy link
Contributor Author

mudit-01 commented Mar 31, 2023

@jaellio @shalier @steeling waiting for your review, Thanks!

@github-actions
Copy link

This PR will be closed due to a long period of inactivity. If you would like this PR to remain open then please comment or update.

@github-actions github-actions bot added the stale label May 31, 2023
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

PR closed due to inactivity.

@github-actions github-actions bot closed this Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants