-
Notifications
You must be signed in to change notification settings - Fork 276
Conversation
Shows message if no mesh exits in the cluster fixes openservicemesh#4697 Signed-off-by: mudit singh <[email protected]>
Hi @mudit-01! Thank you for this fix! Please let us know if need any additional support completing this PR! |
Removed lint error Signed-off-by: mudit singh <[email protected]>
Edited test of Mesh versions with no remote version info Signed-off-by: mudit singh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this contribution!
Codecov Report
@@ Coverage Diff @@
## main #4738 +/- ##
==========================================
+ Coverage 69.08% 69.10% +0.01%
==========================================
Files 227 227
Lines 16311 16314 +3
==========================================
+ Hits 11269 11274 +5
+ Misses 4990 4988 -2
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Added condition for OSM control plane in the cluster Signed-off-by: mudit singh <[email protected]>
Added test for empty remoteVersionInfo Signed-off-by: mudit singh <[email protected]>
Thanks @mudit-01! |
Thank you @jaellio for the review. |
Thanks you @shalier for the review |
@shashankram @nojnhuh @trstringer could I get another review on this? |
@shashankram @trstringer @nojnhuh waiting for your review. |
@shashankram @trstringer @nojnhuh @snehachhabria @draychev could I get another review on this? |
Shows message if no mesh exits in the cluster fixes #4697
Signed-off-by: mudit singh [email protected]
Description:
Testing done: yes
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
Is this a breaking change?
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?