Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

cli: Shows message for no meshes #4738

Merged
merged 8 commits into from
Jun 21, 2022
Merged

Conversation

mudit-01
Copy link
Contributor

Shows message if no mesh exits in the cluster fixes #4697

Signed-off-by: mudit singh [email protected]

Description:

Testing done: yes

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ x]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?

  3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

Shows message if no mesh exits in the cluster fixes openservicemesh#4697

Signed-off-by: mudit singh <[email protected]>
@jaellio
Copy link
Contributor

jaellio commented May 16, 2022

Hi @mudit-01! Thank you for this fix! Please let us know if need any additional support completing this PR!

mudit-01 added 3 commits May 17, 2022 12:11
Removed lint error

Signed-off-by: mudit singh <[email protected]>
Edited test of Mesh versions with no remote version info

Signed-off-by: mudit singh <[email protected]>
@mudit-01 mudit-01 marked this pull request as ready for review May 17, 2022 13:38
Copy link
Contributor

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this contribution!

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #4738 (d95bfbe) into main (0af42df) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4738      +/-   ##
==========================================
+ Coverage   69.08%   69.10%   +0.01%     
==========================================
  Files         227      227              
  Lines       16311    16314       +3     
==========================================
+ Hits        11269    11274       +5     
+ Misses       4990     4988       -2     
  Partials       52       52              
Flag Coverage Δ
unittests 69.10% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/cli/version.go 43.96% <100.00%> (+1.48%) ⬆️
pkg/certificate/manager.go 82.05% <0.00%> (+1.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af42df...d95bfbe. Read the comment docs.

mudit-01 added 3 commits May 20, 2022 15:49
Added condition for OSM control plane in the cluster

Signed-off-by: mudit singh <[email protected]>
Added test for empty remoteVersionInfo

Signed-off-by: mudit singh <[email protected]>
@mudit-01 mudit-01 marked this pull request as draft May 20, 2022 11:09
@mudit-01 mudit-01 marked this pull request as ready for review May 20, 2022 11:35
@mudit-01 mudit-01 requested a review from schristoff May 24, 2022 03:40
@jaellio
Copy link
Contributor

jaellio commented May 28, 2022

Thanks @mudit-01!

@mudit-01
Copy link
Contributor Author

Thank you @jaellio for the review.

@mudit-01
Copy link
Contributor Author

mudit-01 commented Jun 7, 2022

Thanks you @shalier for the review

@jaellio
Copy link
Contributor

jaellio commented Jun 9, 2022

@shashankram @nojnhuh @trstringer could I get another review on this?

@mudit-01
Copy link
Contributor Author

@shashankram @trstringer @nojnhuh waiting for your review.

@mudit-01
Copy link
Contributor Author

@shashankram @trstringer @nojnhuh @snehachhabria @draychev could I get another review on this?

@shashankram shashankram merged commit 905005f into openservicemesh:main Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI version command should specify if no meshes are in the cluster
6 participants