cli: Remove metrics annotation from namespaces removed from the mesh

[mudit-01]

Remove MetricsAnnotation fixes #4447

Signed-off-by: mudit singh [email protected]

Description:

Testing done: yes

Affected area:

Functional Area
New Functionality	[ ]
CI System	[ ]
CLI Tool	[x ]
Certificate Management	[ ]
Control Plane	[ ]
Demo	[ ]
Documentation	[ ]
Egress	[ ]
Ingress	[ ]
Install	[ ]
Networking	[ ]
Observability	[ ]
Performance	[ ]
SMI Policy	[ ]
Security	[ ]
Sidecar Injection	[ ]
Tests	[ ]
Upgrade	[ ]
Other	[ ]

Please answer the following questions with yes/no.

1. Does this change contain code from or inspired by another project?

   • Did you notify the maintainers and provide attribution?

2. Is this a breaking change?

3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

[codecov-commenter]

Codecov Report

Merging #4539 (e908d4f) into main (5c5fcf8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4539      +/-   ##
==========================================
+ Coverage   69.06%   69.08%   +0.01%     
==========================================
  Files         217      217              
  Lines       14758    14759       +1     
==========================================
+ Hits        10193    10196       +3     
+ Misses       4514     4512       -2     
  Partials       51       51              

Flag	Coverage Δ
unittests	69.08% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/cli/namespace_remove.go	80.00% <100.00%> (+0.28%)	⬆️
pkg/certificate/rotor/rotor.go	84.78% <0.00%> (-2.18%)	⬇️
pkg/messaging/workqueue.go	100.00% <0.00%> (+10.71%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c5fcf8...e908d4f. Read the comment docs.

[draychev]

Hi @mudit-01! Thank you so much for contributing this change!
The PR looks great. One tiny comment I have - it would tweak the title of the PR from Metrics annotation removal to something like cli: Remove metrics annotation from namespaces removed from the mesh

The goal would be to:

• contextualize the PR to cli area -- when one glances at the subject/title - it is immediately evident that this is about the CLI component of OSM
• provide context on when the metrics annotation is removed - when a namespace is removed from the mesh

LGTM

[mudit-01]

Hi @mudit-01! Thank you so much for contributing this change! The PR looks great. One tiny comment I have - it would tweak the title of the PR from Metrics annotation removal to something like cli: Remove metrics annotation from namespaces removed from the mesh

The goal would be to:

• contextualize the PR to cli area -- when one glances at the subject/title - it is immediately evident that this is about the CLI component of OSM
• provide context on when the metrics annotation is removed - when a namespace is removed from the mesh

LGTM

Thanks @draychev for the feedback

[mudit-01]

Thanks, @snehachhabria for the review
Thanks, @jaellio for the commit