This repository was archived by the owner on Jul 11, 2023. It is now read-only.
cli: Added checks for without args osm metrics enable/disable command #5021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check if no namespace is mentioned. Signed-off-by: mudit singh <[email protected]>
Added check is no namespace is mentioned. Signed-off-by: mudit singh <[email protected]>
Added test cases for enabling and disabling metrics without namespace. Signed-off-by: mudit singh <[email protected]>
mudit-01
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev,
jaellio,
trstringer,
keithmattix and
steeling
as code owners
mudit-01
changed the title
jsturtevant
reviewed
Aug 24, 2022
Added required flag of namespace in cobra command Signed-off-by: mudit singh <[email protected]>
Added test for checking mandatory namespace args Signed-off-by: mudit singh <[email protected]>
Added comment to ignore lint error of MarkFlagRequired Signed-off-by: mudit singh <[email protected]>
Added MarkFlagRequired to check for namespace for cobra command Signed-off-by: mudit singh <[email protected]>
jsturtevant
approved these changes
Sep 19, 2022
|
Thanks!, @jsturtevant for the review |
keithmattix
approved these changes
Sep 21, 2022
|
Thanks!, @keithmattix for the review |
|
@jaellio @shashankram @steeling @trstringer @nojnhuh can I get another review on this, please? |
jaellio
approved these changes
Sep 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checks for without args osm metrics enable/disable command fixes #4448
Signed-off-by: mudit singh [email protected]
Description:
Testing done: yes
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
Is this a breaking change?
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?