Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

Added test for cert manager #4004

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Added test for cert manager #4004

merged 1 commit into from
Aug 19, 2021

Conversation

mudit-01
Copy link
Contributor

Added test for cert manager for a nil ca Fixes #3437

Signed-off-by: mudit singh [email protected]

Description:

Testing done: yes

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [x ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?

Added test for cert manager for a nil ca Fixes #3437

Signed-off-by: mudit singh <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #4004 (e80dba9) into main (c9d2292) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4004   +/-   ##
=======================================
  Coverage   67.52%   67.53%           
=======================================
  Files         204      204           
  Lines       11615    11615           
=======================================
+ Hits         7843     7844    +1     
+ Misses       3721     3720    -1     
  Partials       51       51           
Flag Coverage Δ
unittests 67.53% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/certificate/providers/tresor/certificate.go 100.00% <0.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9d2292...e80dba9. Read the comment docs.

@mudit-01 mudit-01 marked this pull request as ready for review August 18, 2021 08:13
@mudit-01 mudit-01 requested a review from a team as a code owner August 18, 2021 08:13
@mudit-01
Copy link
Contributor Author

Hi I am not able to figure out why e2e test is failing would appreciate any guidance for the same

@allenlsy
Copy link
Contributor

@mudit-01 The failure was due to pod not coming up in k8s. I guess this can be happen when Action server does not have enough capacity at that moment. Re-run the jobs later can solve the problem.

@mudit-01
Copy link
Contributor Author

thanks @allenlsy for the review

@ksubrmnn ksubrmnn merged commit 7e580ef into openservicemesh:main Aug 19, 2021
@mudit-01
Copy link
Contributor Author

Thanks @ksubrmnn for the review

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: pkg/certificate/providers/tresor/certificate.go - NewCertManager() failures
4 participants