Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

doc: Fixed typo #4792

Merged
merged 1 commit into from
Jun 16, 2022
Merged

doc: Fixed typo #4792

merged 1 commit into from
Jun 16, 2022

Conversation

mudit-01
Copy link
Contributor

@mudit-01 mudit-01 commented Jun 6, 2022

Fixed upper case letter mistake

Signed-off-by: mudit singh [email protected]

Description:

Testing done: NA

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [x ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?

  3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

Fixed upper case letter mistake

Signed-off-by: mudit singh <[email protected]>
@mudit-01 mudit-01 marked this pull request as ready for review June 6, 2022 03:37
@@ -6,7 +6,7 @@
[![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://github.com/openservicemesh/osm/blob/main/LICENSE)
[![release](https://img.shields.io/github/release/openservicemesh/osm/all.svg)](https://github.com/openservicemesh/osm/releases)

Open Service Mesh (OSM) is a lightweight, extensible, Cloud Native [service mesh][1] that allows users to uniformly manage, secure, and get out-of-the-box observability features for highly dynamic microservice environments.
Open Service Mesh (OSM) is a lightweight, extensible, cloud native [service mesh][1] that allows users to uniformly manage, secure, and get out-of-the-box observability features for highly dynamic microservice environments.
Copy link
Contributor

@jaellio jaellio Jun 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this is a typo. If we are referencing the Cloud Native Computing Foundation (CNCF) it might be appropriate to leave this as is. However, if we are broadly referencing the concept of cloud-native technologies this change makes sense to me. @shalier, @phillipgibson what are your thoughts on this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, seems like when CNCF references cloud native they do it like this:
CNCF is the open source, vendor-neutral hub of cloud native computing
So I'm feeling in this use case this is a proper correction. What's your vibe on it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@mudit-01 mudit-01 requested a review from jaellio June 16, 2022 04:21
@shashankram shashankram merged commit 8b1c3cc into openservicemesh:main Jun 16, 2022
@mudit-01
Copy link
Contributor Author

Thanks, @jaellio @shashankram for the review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants