[IMPROVED] Optimizations for PurgeEx from KV PurgeDeletes() clients. #6801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Collison <[email protected]>
Signed-off-by: Derek Collison <[email protected]>
Signed-off-by: Derek Collison <[email protected]>
Filestore specific items. 1. Internal calls to fetch a msg now use a NoCopy version to avoid unecessary allocations. 2. We introduced a last purge time to detect repeated calls to Purge from a client KV PurgeDeletes operation. 3. Access times for cache lifetime management are now from a single ticker updating an atomic every 100ms. 4. filteredPendingLocked now detects non-wildcard filters. 5. AllLastSeqs() is an optimized version to return all last sequences for all subjects. Helpful for KV watchers. 6. Optimized MultiLastSeqs() and allow it to call into AllLastSeqs() when appropriate. 7. Allow multiple tombstones to be written async and flushed all at once. Signed-off-by: Derek Collison <[email protected]>
Signed-off-by: Neil Twigg <[email protected]>
|
ok updated based on PR feedback sans access time ticker which I left a comment on.. /cc @MauriceVanVeen |
Signed-off-by: Derek Collison <[email protected]>
derekcollison
force-pushed
the
last-seqs
branch
from
61cbc7d to
852bfc7
Compare
Merged
neilalexander
added a commit
that referenced
this pull request
Apr 17, 2025
Includes the following (already cherry-picked) PRs: - #6587 - #6607 - #6612 - #6609 - #6620 - #6668 - #6674 - #6647 - #6684 - #6691 - #6697 - #6705 - #6706 - #6704 - #6714 - #6720 - #6727 - #6730 - #6726 - #6732 - #6759 - #6753 - #6685 - #6769 - #6777 - #6785 - #6786 - #6778 - #6790 - #6791 - #6798 - #6794 - #6801 Signed-off-by: Neil Twigg <[email protected]> Signed-off-by: Neil Twigg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various optimizations and introduction of AllLastSeqs().
Filestore specific items.
1. Internal calls to fetch a msg now use a NoCopy version to avoid unnecessary allocations.
2. We introduced a last purge time to detect repeated calls to Purge from a client KV PurgeDeletes operation.
3. Access times for cache lifetime management are now from a single ticker updating an atomic every 100ms.
4. filteredPendingLocked now detects non-wildcard filters.
5. AllLastSeqs() is an optimized version to return all last sequences for all subjects. Helpful for KV watchers.
6. Optimized MultiLastSeqs() and allow it to call into AllLastSeqs() when appropriate.
7. Allow multiple tombstones to be written async and flushed all at once.
Signed-off-by: Derek Collison [email protected]