[FIXED] Stream peers drift after server peer-remove #6720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurice van Veen <[email protected]> Co-authored-by: Neil Twigg <[email protected]>
MauriceVanVeen
force-pushed
the
maurice/server-remove-peers-drift
branch
from
bde74b4 to
273bd5a
Compare
derekcollison
added a commit
that referenced
this pull request
Mar 26, 2025
Related to #6720, but for consumer peer sets. Makes `processClusterCreateConsumer` more aligned with `processClusterCreateStream` by also doing the call to `createRaftGroup`, which proposes the peer change automatically. Signed-off-by: Maurice van Veen <[email protected]>
Merged
neilalexander
added a commit
that referenced
this pull request
Apr 17, 2025
Includes the following (already cherry-picked) PRs: - #6587 - #6607 - #6612 - #6609 - #6620 - #6668 - #6674 - #6647 - #6684 - #6691 - #6697 - #6705 - #6706 - #6704 - #6714 - #6720 - #6727 - #6730 - #6726 - #6732 - #6759 - #6753 - #6685 - #6769 - #6777 - #6785 - #6786 - #6778 - #6790 - #6791 - #6798 - #6794 - #6801 Signed-off-by: Neil Twigg <[email protected]> Signed-off-by: Neil Twigg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a server is peer-removed, a new peer will be selected if the server hosted a stream. That new peer would be given the new peer set by the meta layer, but would then reset back to the old peer set as part of the stream's log.
This is a short-term fix, proposing the new peer set through the stream's log to ensure all replicas agree on it.
Later we'll need to rework some parts to ensure the meta layer only 'suggests' new changes, but the proposing actually goes through the stream/consumer's log instead of meta's log.
Signed-off-by: Maurice van Veen [email protected]
Co-authored-by: Neil Twigg [email protected]