[IMPROVED] NRG: Clarify debug log when clearing WAL #6705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurice van Veen <[email protected]>
|
On a related note, maybe this should be an OR: i.e. |
Merged
wallyqs
changed the title
neilalexander
added a commit
that referenced
this pull request
Apr 17, 2025
Includes the following (already cherry-picked) PRs: - #6587 - #6607 - #6612 - #6609 - #6620 - #6668 - #6674 - #6647 - #6684 - #6691 - #6697 - #6705 - #6706 - #6704 - #6714 - #6720 - #6727 - #6730 - #6726 - #6732 - #6759 - #6753 - #6685 - #6769 - #6777 - #6785 - #6786 - #6778 - #6790 - #6791 - #6798 - #6794 - #6801 Signed-off-by: Neil Twigg <[email protected]> Signed-off-by: Neil Twigg <[email protected]>
neilalexander
added a commit
that referenced
this pull request
Jun 3, 2025
Usually `Resetting WAL state` is a prime indicator something went horribly wrong with replication, and resetting is our last effort at fixing things. Antithesis reports on this being logged so we can look into it and fix the condition. However, this also triggers if the WAL is empty, a leader gets elected and stores a message that doesn't get quorum. Once a new leader is elected and this entry without quorum gets removed, we'd also log `Resetting WAL state` even though this is a normal condition. If we have made no commits, it's safe to reset/clear the WAL. This PR changes the log line to clarify this. Relates to #6705 Signed-off-by: Maurice van Veen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change there were two log statements:
WRN Resetting WAL stateandDBG Resetting WAL. Whenever a WAL needs to be reset, when looking at the WRN log, it means something went wrong and we can't properly replicate (which could result in desync). The DBG log however looks just as scary but actually is harmless. You'd see that log message when truncating the WAL back to applied/snapshot, which is normal and can happen.Updating the wording in the DBG log to clearly differentiate between a (bad) reset and clearing/truncating the WAL which is normal in this case.
Signed-off-by: Maurice van Veen [email protected]