Skip to content

[FIXED] Data race in configureAccounts #6620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

MauriceVanVeen
Copy link
Member

s.sys = nil is called in shutdownEventing() while holding the lock. But configureAccounts reads after unlocking.

=== RUN   TestConfigReloadNoPanicOnShutdown
==================
WARNING: DATA RACE
Write at 0x00c0000ca330 by goroutine 132061:
  github.com/nats-io/nats-server/v2/server.(*Server).shutdownEventing()
      /home/travis/build/nats-io/nats-server/server/events.go:1831 +0x1f0
Previous read at 0x00c0000ca330 by goroutine 131431:
  github.com/nats-io/nats-server/v2/server.(*Server).configureAccounts()
      /home/travis/build/nats-io/nats-server/server/server.go:1387 +0x1245

Signed-off-by: Maurice van Veen [email protected]

Signed-off-by: Maurice van Veen <[email protected]>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner March 10, 2025 09:57
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 842f06c into main Mar 10, 2025
5 checks passed
@neilalexander neilalexander deleted the maurice/configure-shutdown-race branch March 10, 2025 10:50
@wallyqs wallyqs changed the title Data race in configureAccounts [FIXED] Data race in configureAccounts Apr 17, 2025
neilalexander added a commit that referenced this pull request Apr 17, 2025
Includes the following (already cherry-picked) PRs:

- #6587
- #6607
- #6612
- #6609
- #6620
- #6668
- #6674
- #6647
- #6684
- #6691
- #6697
- #6705
- #6706
- #6704
- #6714
- #6720
- #6727
- #6730
- #6726
- #6732
- #6759
- #6753
- #6685
- #6769
- #6777
- #6785
- #6786
- #6778
- #6790
- #6791
- #6798
- #6794
- #6801

Signed-off-by: Neil Twigg <[email protected]>

Signed-off-by: Neil Twigg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants