[FIXED] JetStream: cross-account mirror with subject transform issue #6759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using import/export, if one tries to limit the consumer create API with specific stream name and subject filter, the sync of a mirror would fail if using a single subject transform. This PR checks that if there is no filter subject, but a single entry in FilterSubjects, then we switch to simple FilterSubject as to allow the use of the extended consumer create API that allows for fine grained permissions. Resolves #6751 Signed-off-by: Ivan Kozlovic <[email protected]>
|
@derekcollison @jnmoyne @ripienaar I would like you to have a look at this PR. It looks like what was done for source streams was not done for mirrors. I took a slightly different approach that for sources, but it is equivalent, that is, if there is no FilterSubject config and a single SubjectTransforms entry, then use that one as a FilterSubject, which allows the use of the extended consumer create API. It looks like |
Merged
neilalexander
added a commit
that referenced
this pull request
Apr 17, 2025
Includes the following (already cherry-picked) PRs: - #6587 - #6607 - #6612 - #6609 - #6620 - #6668 - #6674 - #6647 - #6684 - #6691 - #6697 - #6705 - #6706 - #6704 - #6714 - #6720 - #6727 - #6730 - #6726 - #6732 - #6759 - #6753 - #6685 - #6769 - #6777 - #6785 - #6786 - #6778 - #6790 - #6791 - #6798 - #6794 - #6801 Signed-off-by: Neil Twigg <[email protected]> Signed-off-by: Neil Twigg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using import/export, if one tries to limit the consumer create API with specific stream name and subject filter, the sync of a mirror would fail if using a single subject transform.
This PR checks that if there is no filter subject, but a single entry in FilterSubjects, then we switch to simple FilterSubject as to allow the use of the extended consumer create API that allows for fine grained permissions.
Resolves #6751
Signed-off-by: Ivan Kozlovic [email protected]