Upgrade from Chromium 88 to Chromium 89 (1.21.x). #8009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade from Chromium 88 to Chromium 89.
[Settings] fixes clicking 'Additional settings'.
Upgrade patches from Chromium 89.0.4389.40 to Chromium 89.0.4389.48
Android settings fixes
Upgrade patches from Chromium 89.0.4389.48 to Chromium 89.0.4389.58.
Disables Safe Browsing Enhanced Protection message in interstitials.
mkarolin
requested review from
iefremov,
samartnik,
simonhong,
tmancey and
a team
as code owners
23 tasks
| </if> | ||
| <message name="IDS_SETTINGS_PEOPLE_SIGN_IN_PROMPT_SECONDARY_WITH_ACCOUNT" desc="The secondary text displayed to prompt users to enable sync for an account that is alredy present in Brave."> | ||
| Sync and personalize Brave across your devices | ||
| </message> | ||
| <if expr="chromeos"> | ||
| <message name="IDS_SETTINGS_ACCOUNT_MANAGER_DESCRIPTION_V2" desc="Description of the Account Manager Settings page. Shown just below the title of the page."> |
There was a problem hiding this comment.
Seems Chromium leftover, Chromebook => Bravebook
AlexeyBarabash
approved these changes
Feb 21, 2021
simonhong
approved these changes
Feb 22, 2021
[Android] Fixed url for shields
kjozwiak
approved these changes
Feb 23, 2021
There was a problem hiding this comment.
Uplift into 1.21.x approved after deliberating with @brave/uplift-approvers. QA went through the manual passes as per brave/brave-browser#13968 & brave/qa-resources#207.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#13238
Fixes brave/brave-browser#14065
Fixes brave/brave-browser#14112
Fixes brave/brave-browser#14165
Fixes brave/brave-browser#14167
Fixes brave/brave-browser#14227
Fixes brave/brave-browser#14235
Fixes brave/brave-browser#14284
Related PR: brave/brave-browser#14255
Uplift from #7460
Uplift from #7900
Uplift from #7936
Uplift from #7975
Uplift from #7988
Uplift from #8000
Uplift from #8027
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: