Skip to content

Interstitial page points to Enhanced protection which isn't available #14235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srirambv opened this issue Feb 18, 2021 · 2 comments · Fixed by brave/brave-core#8000
Closed

Interstitial page points to Enhanced protection which isn't available #14235

srirambv opened this issue Feb 18, 2021 · 2 comments · Fixed by brave/brave-core#8000
Assignees
@mkarolin
Labels
branding bug feature/settings OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.21.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 18, 2021 •
edited by stephendonner
Loading

Description

Interstitial page points to Enhanced protection which isn't available

Steps to Reproduce

  1. Load any cert error pages like https://untrusted-root.badssl.com/
  2. Shows interstitial page
  3. Info box has a hyper link for To get Brave’s highest level of security, turn on enhanced protection which links to chrome-error://chromewebdata/# which deep links into settings brave://settings/security?q=enhanced which is not available in Brave

Actual result:

image

Expected result:

Remove all entries for non-existent settings

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.22.31 Chromium: 89.0.4389.48 (Official Build) nightly (64-bit)
Revision 0fe3c4589a6cf5ce719d167834dfa9cd8978937a-refs/branch-heads/4389@{#873}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @mkarolin @jumde @rebron
@srirambv
Copy link
Contributor Author

Logged #14237 for Google support links which seems to be an issue on current release builds as well. Also updated the issue to only mention the missing settings

@mkarolin mkarolin mentioned this issue Feb 18, 2021
Merged
23 tasks
@stephendonner stephendonner changed the title Interstitial page points to Enhanced protection which isn't avialable Interstitial page points to Enhanced protection which isn't available Feb 18, 2021
@mkarolin mkarolin self-assigned this Feb 18, 2021
mkarolin added a commit to brave/brave-core that referenced this issue Feb 18, 2021
@mkarolin
Disables Safe Browsing Enhanced Protection message in interstitials.
b3f3f76 
Fixes brave/brave-browser#14235

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/fc0d1b93b039972a96eead77dd4d6f359762afcc

commit fc0d1b93b039972a96eead77dd4d6f359762afcc
Author: Xinghui Lu <[email protected]>
Date:   Thu Jan 14 03:21:12 2021 +0000

    Enable enhanced protection message in interstitials by default.

    To fully replace the old SBER checkbox with the new enhanced protection
    message, some tests are removed entirely because the SBER checkbox
    doesn't exist anymore:
    SafeBrowsingBlockingPageBrowserTest.VisitWhitePaper
    SafeBrowsingBlockingPageBrowserTest.ToggleSBEROn
    SafeBrowsingBlockingPageBrowserTest.ToggleSBEROff

    Some tests are slightly modified by removing the old
    extended-reporting-opt-in element:
    SafeBrowsingBlockingPageBrowserTest.
      MainFrameBlockedShouldHaveNoDOMDetails
    SafeBrowsingBlockingPageBrowserTest.ReloadWhileInterstitialShowing
    SafeBrowsingBlockingPageBrowserTest.VerifyHitReportNotSentOnIncognito

    For PolicyTest, remove the check of opt-in checkbox in
    SafeBrowsingExtendedReportingPolicyManaged and add a new test for
    checking the new enhanced-protection-message message with the
    kSafeBrowsingProtectionLevel policy.

    Bug: 1130721
@mkarolin mkarolin mentioned this issue Feb 18, 2021
Merged
23 tasks
@mkarolin mkarolin added this to the 1.22.x - Nightly milestone Feb 18, 2021
@mkarolin mkarolin mentioned this issue Feb 19, 2021
Merged
23 tasks
@stephendonner
Copy link

stephendonner commented Feb 22, 2021 •
edited by btlechowski
Loading

Verified FIXED on nightly using

Brave 1.22.39 Chromium: 89.0.4389.58 (Official Build) nightly (x86_64)
Revision 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS macOS Version 11.2.1 (Build 20D74)

Verified that the "turn on enhanced protection" message in the interstitial page is now removed.

Screen Shot 2021-02-22 at 12 30 15 PM

Verification passed on


Brave | 1.21.68 Chromium: 89.0.4389.58 (Official Build) (64-bit)
-- | --
Revision | 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS | Windows 10 OS Version 2004 (Build 19041.804)

Reproduced the CR 89 issue in 1.22.31 nightly build
image
image

Verified the various interstitial pages and confirmed that the "turn on enhanced protection" message is removed in 1.21.68
https://untrusted-root.badssl.com/
https://testsafebrowsing.appspot.com/s/phishing.html

image
image

Verification passed on

Brave 1.21.68 Chromium: 89.0.4389.58 (Official Build) (64-bit)
Revision 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS Ubuntu 18.04 LTS

Verified test plan from the description
https://untrusted-root.badssl.com/
image

https://testsafebrowsing.appspot.com/s/phishing.html
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
branding bug feature/settings OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.21.x - Release
Development

Successfully merging a pull request may close this issue.

Disables Safe Browsing Enhanced Protection message in interstitials. brave/brave-core
6 participants
@stephendonner @kjozwiak @srirambv @btlechowski @GeetaSarvadnya @mkarolin