Skip to content

Upgrade from Chromium 88 to Chromium 89. #7460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 151 commits into from
Feb 5, 2021
Merged

Upgrade from Chromium 88 to Chromium 89. #7460

merged 151 commits into from
Feb 5, 2021

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Dec 16, 2020 •
edited
Loading

Fixes brave/brave-browser#13238
Related PR: brave/brave-browser#13221

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin added the CI/run-network-audit Run network-audit label Dec 16, 2020
@mkarolin mkarolin self-assigned this Dec 16, 2020
@mkarolin mkarolin force-pushed the cr89 branch 2 times, most recently from c779c38 to b936c2b Compare December 17, 2020 05:40
@mkarolin mkarolin mentioned this pull request Dec 17, 2020
Merged
23 tasks
@mkarolin mkarolin force-pushed the cr89 branch 2 times, most recently from 1039ec2 to c00e574 Compare December 23, 2020 19:47
@mariospr mariospr force-pushed the cr89 branch 8 times, most recently from 06e61d2 to 1a3458a Compare January 14, 2021 12:57
@mariospr mariospr force-pushed the cr89 branch 7 times, most recently from f0a7262 to fca4efd Compare January 21, 2021 17:47
@mkarolin mkarolin changed the title Upgrade from Chromium 88 to Chromium 89. WIP: Upgrade from Chromium 88 to Chromium 89. Jan 23, 2021
@mkarolin mkarolin marked this pull request as ready for review January 23, 2021 00:41
mkarolin and others added 18 commits February 4, 2021 23:52
@mkarolin
Formatting fix.
cd80304
@mkarolin
Use ScopedObservation in BraveProfileImpl.
a519a37
@mkarolin
cr89 code review: removed unneeded code from BatteryManager.
81113aa
@mkarolin
Conflict-resolved patches from Chromium 89.0.4389.23 to Chromium 89.0…
bf7c697 
….4389.40.
@mkarolin
Updated patches from Chromium 89.0.4389.23 to Chromium 89.0.4389.40.
59036ac
@mkarolin
Updated strings for 89.0.4389.40.
0db3783
@mkarolin
Updated optimize_webui.gni patch.
a81f4eb
@bridiver @mkarolin
remove includes that no longer apply
09e3f08
@bridiver @mkarolin
shield_exceptions should never have been in common in the first place…
15a3a4f 
…, but it's only called in one place now so we don't need a separate target for it
@bridiver @mkarolin
add visibility lists to prevent more layering violations
64caf8d
@bridiver @mkarolin
format
c6f462e
@bridiver @mkarolin
add visibility lists for brave/browser and break out existing violations
0dfed66
@mkarolin
Adjusted visibility for //brave/common targets for iOS and Android.
b34a457
@mkarolin
Formatting fixes.
2087ea6
@mkarolin
BubbleBorder::NO_ASSETS -> NO_SHADOW.
a66f6ed 
Chromium change:

https://source.chromium.org/chromium/chromium/src/+/e2cf5fa1f67d34996c217249a3664e943de7f5d8

commit e2cf5fa1f67d34996c217249a3664e943de7f5d8
Author: Wei Li <[email protected]>
Date:   Thu Jan 7 18:36:22 2021 +0000

    Simplify bubble border shadow types

    Merge SMALL_SHADOW and BIG_SHADOW types into one STANDARD_SHADOW type as
    they are essentially same. Rename NO_SHADOW to NO_SHADOW_LEGACY as it
    is only needed to support bubbles on the legacy Win7 platform. We would
    remove it when win7 is no longer supported. Thus rename to NO_ASSETS to
    NO_SHADOW.

    After this change, bubble border shadow types boil down to just two
    usable types: STANDARD_SHADOW and NO_SHADOW. They represent standard
    (MD style) shadow and no shadow cases respectively.

    Fixed: 940027
@Brandon-T @mkarolin
Fixing iOS syncing.
508a997
@mkarolin
Formatting fixes.
96fd63a
@mkarolin
Lint fixes.
f6c85a6
@mkarolin
Copy link
Collaborator Author

mkarolin commented Feb 5, 2021

CI Passed.

@mkarolin mkarolin merged commit 2818ddc into master Feb 5, 2021
@mkarolin mkarolin deleted the cr89 branch February 5, 2021 14:20
@mkarolin mkarolin added this to the 1.22.x - Nightly milestone Feb 5, 2021
@mkarolin
Copy link
Collaborator Author

mkarolin commented Feb 9, 2021 •
edited by AlexeyBarabash
Loading

When uplifting, also uplift:

mkarolin added a commit that referenced this pull request Feb 11, 2021
@mkarolin
Merge pull request #7460 from brave/cr89
26eb58e 
Upgrade from Chromium 88 to Chromium 89.
mkarolin added a commit that referenced this pull request Feb 16, 2021
@mkarolin
Merge pull request #7460 from brave/cr89
b4fe5d9 
Upgrade from Chromium 88 to Chromium 89.
mkarolin added a commit that referenced this pull request Feb 19, 2021
@mkarolin
Merge pull request #7460 from brave/cr89
0017002 
Upgrade from Chromium 88 to Chromium 89.
@mkarolin mkarolin mentioned this pull request Feb 19, 2021
Merged
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pes10k pes10k pes10k left review comments

@darkdh darkdh darkdh left review comments

@AlexeyBarabash AlexeyBarabash AlexeyBarabash left review comments

@bridiver bridiver bridiver approved these changes

@tmancey tmancey tmancey approved these changes

@iefremov iefremov iefremov approved these changes

@simonhong simonhong simonhong approved these changes

@samartnik samartnik samartnik approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@bsclifton bsclifton Awaiting requested review from bsclifton

@petemill petemill Awaiting requested review from petemill

Assignees

@mkarolin mkarolin

Labels
CI/run-network-audit Run network-audit
Projects
None yet
Milestone
1.22.x - Release
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 88 to Chromium 89.