Skip to content

Shields disabled on new sites #14284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srirambv opened this issue Feb 22, 2021 · 1 comment · Fixed by brave/brave-core#8027
Closed

Shields disabled on new sites #14284

srirambv opened this issue Feb 22, 2021 · 1 comment · Fixed by brave/brave-core#8027
Assignees
Labels
bug OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass - Android Tab QA/Yes regression release/blocking release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Shields disabled on new sites

Steps to reproduce

  1. Clean install 1.22.39 x64 nightly build
  2. Visit a site and disable shields
  3. Visit a new page on the same tab, shields is disabled
  4. Open a new tab and visit a different page, shields disabled on the new page as well

Actual result

Android.Shields.mp4

Expected result

Shields should not be disabled on all pages when its disabled on one page

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.22.39 x64 nightly

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

@srirambv
Copy link
Contributor Author

Verification passed on OnePlus 6T with Android 10 running 1.21.69 x64 build

  • Verified steps from issue description

Verification passed on Samsung Tab A with Android 10 running 1.21.69 x64 build

  • Verified steps from issue description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass - Android Tab QA/Yes regression release/blocking release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants