Skip to content

Privacy settings order is different in CR89 #14167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srirambv opened this issue Feb 16, 2021 · 5 comments · Fixed by brave/brave-core#7975
Closed

Privacy settings order is different in CR89 #14167

srirambv opened this issue Feb 16, 2021 · 5 comments · Fixed by brave/brave-core#7975

Comments

@srirambv
Copy link
Contributor

Description

Privacy settings order is different in CR89

Steps to reproduce

  1. Install 1.22.27 x64 nightly build
  2. Open Privacy and security settings
  3. Order of the setting is changed

Actual result

1.20.103 1.22.27
image image

Expected result

Not sure if the order should be changed or kept it as is

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.22.27 x64 nightly

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @anthonypkeane @SergeyZhukovsky @samartnik

@samartnik samartnik self-assigned this Feb 16, 2021
@samartnik
Copy link
Contributor

Yes, they reordered it in upstream, I'll fix it.

@samartnik
Copy link
Contributor

I didn't change order on Chromium's side, just moved all our settings to the end. Now it looks like this
device-2021-02-16-152439
device-2021-02-16-152456
device-2021-02-16-152504

@srirambv
Copy link
Contributor Author

@samartnik @bsclifton should we get #6831done with this reorder?

cc: @anthonypkeane

@samartnik
Copy link
Contributor

I believe #6831 is a separate issue as it's not related to changes in upstream. This one just adjusts our code to their changes.

@srirambv
Copy link
Contributor Author

Verification passed on the following devices with Android 10 running 1.21.68 x64 build

OnePlus 6T Samsung Tab A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants