Skip to content

Cert Errors interstitial page links to Google Support pages #14237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srirambv opened this issue Feb 18, 2021 · 11 comments
Closed

Cert Errors interstitial page links to Google Support pages #14237

srirambv opened this issue Feb 18, 2021 · 11 comments
Labels
branding closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Cert Errors interstitial page links to Google Support pages

Steps to Reproduce

  1. Load any cert error pages like https://untrusted-root.badssl.com/
  2. Shows interstitial page
  3. Learn more on the info links to chrome-error://chromewebdata/# which redirects to https://support.google.com/chrome/answer/6098869

Actual result:

Cert Errors interstitial page links to Google Support pages

Expected result:

Should redirect to specific articles on https://support.brave.com/

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.22.31 Chromium: 89.0.4389.48 (Official Build) nightly (64-bit)
Revision 0fe3c4589a6cf5ce719d167834dfa9cd8978937a-refs/branch-heads/4389@{#873}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

Looks like this was not fixed as part of #212 or was done but then regressed down the line. @rebron @bsclifton @bbondy @mkarolin we should prioritize this one and have it fixed before channel migration. Tagging @hollons @Brave-Matt to have the support links ready for this.

@srirambv srirambv added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include branding OS/Desktop labels Feb 18, 2021
mkarolin added a commit to brave/brave-core that referenced this issue Feb 19, 2021
Added chromium_src overrides that currently direct "Learn more" links on
interstitial pages to support.brave.com. This will need to be adjusted
when we have specific article(s).

Fixes brave/brave-browser#14237
mkarolin added a commit to brave/brave-core that referenced this issue Feb 22, 2021
Added chromium_src overrides that currently direct "Learn more" links on
interstitial pages to support.brave.com. This will need to be adjusted
when we have specific article(s).

Fixes brave/brave-browser#14237
@rebron
Copy link
Collaborator

rebron commented Mar 2, 2021

cc: @Brave-Matt Can we get a similar article to our support site?

@mkarolin
Copy link
Contributor

@Brave-Matt @hollons ping ☝️

@Brave-Matt
Copy link

@mkarolin @rebron we certainly can -- is it safe to assume that all the error codes/messages will apply to us as well? So I'm mostly able to just copy the info over?

@mkarolin
Copy link
Contributor

@Brave-Matt yes, all the same error codes would apply to us.

@Brave-Matt
Copy link

Got it -- can have this up soon 👍

@Brave-Matt
Copy link

Sorry for the delay -- this doc is up and ready to be viewed. Link here:
https://support.brave.com/hc/en-us/articles/360059254971

@mkarolin
Copy link
Contributor

mkarolin commented Apr 6, 2021

Looks like Safe Browsing interstitial page also has a Learn more link that redirects to a different article (namely https://support.google.com/chrome/answer/99020).
STR:

  1. Load a safe browsing test page (like https://testsafebrowsing.appspot.com/s/phishing.html)
  2. Shows interstitial page
  3. Learn more on the info links to chrome-error://chromewebdata/# which redirects to https://support.google.com/chrome/?p=cpn_safe_browsing (resolves to https://support.google.com/chrome/answer/99020)

cc: @Brave-Matt do we already have a page similar to this one?

cc: @rebron @jumde There is also a couple of links if you click on Details button that take you to Google to see the site status or report Safe Browsing error. I am not sure if anything needs to be done to those.

mkarolin added a commit to brave/brave-core that referenced this issue Apr 6, 2021
Added chromium_src overrides that currently direct "Learn more" links on
interstitial pages to support.brave.com. This will need to be adjusted
when we have specific article(s).

Fixes brave/brave-browser#14237
@mkarolin
Copy link
Contributor

Ping @Brave-Matt ☝️

@rebron
Copy link
Collaborator

rebron commented May 12, 2021

cc: @rebron @jumde There is also a couple of links if you click on Details button that take you to Google to see the site status or report Safe Browsing error. I am not sure if anything needs to be done to those.

The links in details seems fine to me. Feature should still be branded Google Safe Browsing and links out to this service looks right.

@Brave-Matt
Copy link

I've been slacking on this doc and I apologize. I'll get something up for us to link to this week but it is on the board:
https://github.com/brave/support/issues/1047

@bsclifton
Copy link
Member

Closing as stale. Per above comment, linking to Google is OK in this context as the interstitial is being presented via Google's Safe Browsing service

@bsclifton bsclifton added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branding closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants