-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Cert Errors interstitial page links to Google Support pages #14237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Added chromium_src overrides that currently direct "Learn more" links on interstitial pages to support.brave.com. This will need to be adjusted when we have specific article(s). Fixes brave/brave-browser#14237
Added chromium_src overrides that currently direct "Learn more" links on interstitial pages to support.brave.com. This will need to be adjusted when we have specific article(s). Fixes brave/brave-browser#14237
cc: @Brave-Matt Can we get a similar article to our support site? |
@Brave-Matt @hollons ping ☝️ |
@Brave-Matt yes, all the same error codes would apply to us. |
Got it -- can have this up soon 👍 |
Sorry for the delay -- this doc is up and ready to be viewed. Link here: |
Looks like Safe Browsing interstitial page also has a
cc: @Brave-Matt do we already have a page similar to this one? cc: @rebron @jumde There is also a couple of links if you click on |
Added chromium_src overrides that currently direct "Learn more" links on interstitial pages to support.brave.com. This will need to be adjusted when we have specific article(s). Fixes brave/brave-browser#14237
Ping @Brave-Matt ☝️ |
The links in details seems fine to me. Feature should still be branded Google Safe Browsing and links out to this service looks right. |
I've been slacking on this doc and I apologize. I'll get something up for us to link to this week but it is on the board: |
Closing as stale. Per above comment, linking to Google is OK in this context as the interstitial is being presented via Google's Safe Browsing service |
Description
Cert Errors interstitial page links to Google Support pages
Steps to Reproduce
https://support.google.com/chrome/answer/6098869
Actual result:
Cert Errors interstitial page links to Google Support pages
Expected result:
Should redirect to specific articles on
https://support.brave.com/
Reproduces how often:
Easy
Brave version (brave://version info)
0fe3c4589a6cf5ce719d167834dfa9cd8978937a-refs/branch-heads/4389@{#873}
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
Looks like this was not fixed as part of #212 or was done but then regressed down the line. @rebron @bsclifton @bbondy @mkarolin we should prioritize this one and have it fixed before channel migration. Tagging @hollons @Brave-Matt to have the support links ready for this.
The text was updated successfully, but these errors were encountered: