Skip to content

Wrong text for link in Private Window New tab #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
btlechowski opened this issue Sep 24, 2018 · 1 comment · Fixed by brave/brave-core#542
Closed

Wrong text for link in Private Window New tab #1262

btlechowski opened this issue Sep 24, 2018 · 1 comment · Fixed by brave/brave-core#542
Assignees
@cezaraugusto
Labels
feature/new-tab feature/private-browsing QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Open New tab in Private Window

Actual result:

Link is https://github.com/brave/browser-laptop/wiki/Using-Tor-in-Brave#faq
text is Search Preferences

image

Expected result:

Link is https://github.com/brave/browser-laptop/wiki/Using-Tor-in-Brave#faq
text is Learn more

Reproduces how often:

always

Brave version (chrome://version info)

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Reproducible on current release:

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

@srirambv @kjozwiak @LaurenWags @bsclifton @GeetaSarvadnya @cezaraugusto
@btlechowski btlechowski mentioned this issue Sep 24, 2018
Closed
@cezaraugusto cezaraugusto self-assigned this Sep 24, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Sep 30, 2018
cezaraugusto added a commit to brave/brave-core that referenced this issue Oct 2, 2018
@cezaraugusto
fix wrong strings in tor/incognito newtab windows
3e592c5 
fix brave/brave-browser#1262
fix brave/brave-browser#1263
@cezaraugusto cezaraugusto mentioned this issue Oct 2, 2018
Merged
@bsclifton bsclifton modified the milestones: 1.x Backlog, Releasable builds 0.55.x Oct 2, 2018
@btlechowski
Copy link
Author

btlechowski commented Oct 9, 2018 •
edited by kjozwiak
Loading

Verification passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Windows 7

image

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X

screen shot 2018-10-10 at 10 19 48 am

@MadhaviSeelam MadhaviSeelam mentioned this issue Jul 20, 2022
Open
@wooque wooque mentioned this issue Jul 20, 2022
Closed
@dalmo3 dalmo3 mentioned this issue Jul 21, 2022
Closed
@leotm leotm mentioned this issue Jul 21, 2022
Closed
@NotII NotII mentioned this issue Jul 21, 2022
Closed
@simplyhexagon simplyhexagon mentioned this issue Jul 22, 2022
Open
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jul 22, 2022
Open
@LaurenWags LaurenWags mentioned this issue Jul 22, 2022
Closed
@urbenlegend urbenlegend mentioned this issue Jul 25, 2022
Open
This was referenced Jul 26, 2022
Closed
Closed
Closed
@MadhaviSeelam MadhaviSeelam mentioned this issue Jul 26, 2022
Closed
@Uni-verse Uni-verse mentioned this issue Jul 27, 2022
Closed
@btlechowski btlechowski mentioned this issue Jul 27, 2022
Closed
This was referenced Jul 28, 2022
Closed
Closed
@glitchhg glitchhg mentioned this issue Jul 28, 2022
Open
This was referenced Jul 28, 2022
Closed
Closed
Closed
@srk1195 srk1195 mentioned this issue Jul 29, 2022
Open
@MadhaviSeelam MadhaviSeelam mentioned this issue Jul 29, 2022
Closed
@arch-user-france1 arch-user-france1 mentioned this issue Jul 31, 2022
Open
@bryonbaker bryonbaker mentioned this issue Aug 8, 2022
Closed
@kwsp kwsp mentioned this issue Aug 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
feature/new-tab feature/private-browsing QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

fix wrong strings in tor/incognito newtab windows brave/brave-core
6 participants
@bbondy @kjozwiak @cezaraugusto @bsclifton @srirambv @btlechowski