Skip to content

fix wrong strings in tor/incognito newtab windows #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

cezaraugusto
Copy link
Contributor

fix brave/brave-browser#1262
fix brave/brave-browser#1263

Test Plan: Private/Tor window should have the right strings as defined in the issues above

@cezaraugusto cezaraugusto self-assigned this Oct 2, 2018
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 78da248 into master Oct 2, 2018
@bsclifton bsclifton deleted the tor-incognito-wrong-strings branch October 2, 2018 05:47
bsclifton added a commit that referenced this pull request Oct 2, 2018
fix wrong strings in tor/incognito newtab windows
bsclifton added a commit that referenced this pull request Oct 2, 2018
fix wrong strings in tor/incognito newtab windows
@bsclifton
Copy link
Member

master 78da248
0.56.x e666554
0.55.x b19ad36

@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong text for link in Private Window with Tor New tab Wrong text for link in Private Window New tab
4 participants