Skip to content

WDP dialog is launched from private window #24118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simonhong opened this issue Jul 19, 2022 · 3 comments · Fixed by brave/brave-core#14222
Closed

WDP dialog is launched from private window #24118

simonhong opened this issue Jul 19, 2022 · 3 comments · Fixed by brave/brave-core#14222

Comments

@simonhong
Copy link
Member

Description

WDP dialog should not be launched from private window

Steps to Reproduce

  1. Launch Brave with clean profile
  2. Set Brave as a Private window's default provider
  3. Launch private window
  4. Create NTP and type search.brave.com
  5. Repeat above step 4 3 times

Actual result:

WDP dialog is visible
Screen Shot 2022-07-19 at 7 27 04 AM

Expected result:

It should not visible

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@kjozwiak
Copy link
Member

The above will require 1.42.78 or higher for 1.42.x verification 👍

@btlechowski
Copy link

Verification passed on

Brave 1.42.78 Chromium: 103.0.5060.134 (Official Build) beta (64-bit)
Revision 8ec6fce403b3feb0869b0732eda8bd95011d333c-refs/branch-heads/5060@{#1262}
OS Ubuntu 18.04 LTS

Reproduce in 1.42.74
image

Verified test plan from the description

Set Brave as default search engine for Private Window
image

Verified WDP dialog is not shown
image

@LaurenWags
Copy link
Member

Updated to release-notes/exclude per discussion with @rebron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants