We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WDP dialog should not be launched from private window
WDP dialog is visible
It should not visible
The text was updated successfully, but these errors were encountered:
Fixed WDP dialog is launched from private window
ea2ee30
fix brave/brave-browser#24118 Fixed by not attaching tab helpers to WebContents from private profile.
The above will require 1.42.78 or higher for 1.42.x verification 👍
1.42.78
1.42.x
Sorry, something went wrong.
Verification passed on
Reproduce in 1.42.74
Verified test plan from the description
Set Brave as default search engine for Private Window
Verified WDP dialog is not shown
Updated to release-notes/exclude per discussion with @rebron
release-notes/exclude
simonhong
Successfully merging a pull request may close this issue.
Description
WDP dialog should not be launched from private window
Steps to Reproduce
Actual result:
WDP dialog is visible

Expected result:
It should not visible
Reproduces how often:
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: