Skip to content

Try to trigger NTP SI on each NTP refresh #24107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
btlechowski opened this issue Jul 18, 2022 · 3 comments · Fixed by brave/brave-core#14225
Closed

Try to trigger NTP SI on each NTP refresh #24107

btlechowski opened this issue Jul 18, 2022 · 3 comments · Fixed by brave/brave-core#14225
Assignees
@aseren
Labels
feature/ads OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA/Test-Plan-Specified QA/Yes release/blocking release-notes/exclude
Milestone
1.42.x - Release

Comments

@btlechowski
Copy link

NTP SI is shown every other trigger

Steps to Reproduce

  1. Clean profile
  2. Enable rewards and ads
  3. Trigger a NTP SI

Actual result:

On 1st trigger the logs shown that NTP SI is served, but in reality it is not shown.
1st NTP SI trigger

[7543:7543:0718/172818.656724:VERBOSE1:eligible_new_tab_page_ads_v1.cc(38)] Get eligible new tab page ads:
[7543:7543:0718/172818.660156:VERBOSE1:eligible_new_tab_page_ads_v1.cc(161)] Get eligible ads for untargeted segment
[7543:7543:0718/172818.664079:VERBOSE1:seen_advertisers.h(29)] All new_tab_page_ad advertisers have been shown, so round robin
[7543:7543:0718/172818.664615:VERBOSE1:client_state_manager.cc(463)] Resetting seen new_tab_page_ad advertisers
[7543:7543:0718/172818.666334:VERBOSE2:priority.h(33)] 2 ads with a priority of 1 in bucket 1
[7543:7543:0718/172818.669532:VERBOSE1:eligible_new_tab_page_ads_v1.cc(181)] 2 eligible ads out of 2 ads for untargeted segment
[7543:7543:0718/172818.669705:VERBOSE1:new_tab_page_ad_serving.cc(89)] Found 2 eligible ads
[7543:7543:0718/172818.669884:VERBOSE1:new_tab_page_ad_serving.cc(139)] Serving new tab page ad:
  placementId: 36ba06d2-fd01-4fc8-9e78-b4283f6a6a7b
  creativeInstanceId: 04af6c03-deed-4d6d-be5d-c11a9817e1de
  creativeSetId: a8cac5f9-e575-46da-a20e-d8e82d9a6953
  campaignId: f74b3bb4-8087-4084-b8be-bd2c9f23f7b3
  advertiserId: 2b98768c-ef1d-4b7f-8f92-d6340123094e
  segment: untargeted
  companyName: NAGA
  imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/b067388e-dfb0-49ad-b54f-106c2cc56f93.png
  alt: Copy the best performing crypto and stock traders with NAGA Super Investing App.
  targetUrl: https://nagamarkets.com/start-investing-with-naga/?utm_campaign=la-brave-image-campaign&utm_source=brave&utm_medium=braveimage&utm_content=images
  wallpaperImageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/e19f2ac5-60b4-44c8-bf1b-7504b426a4cc.jpeg
  wallpaperFocalPointX: 1280
  wallpaperFocalPointY: 720
[7543:7543:0718/172818.670547:VERBOSE1:new_tab_page_ad_serving.cc(101)] Served new tab page ad
[7543:7543:0718/172818.699151:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 36ba06d2-fd01-4fc8-9e78-b4283f6a6a7b and creative instance id 04af6c03-deed-4d6d-be5d-c11a9817e1de
[7543:7543:0718/172818.721154:VERBOSE6:new_tab_page_ad_event_served.cc(31)] Successfully logged new tab page ad served event

image

2st NTP SI trigger, NTP SI is viewed and actually shown to the user


[7543:7543:0718/173421.375465:VERBOSE1:eligible_new_tab_page_ads_v1.cc(38)] Get eligible new tab page ads:
[7543:7543:0718/173421.391269:VERBOSE1:eligible_new_tab_page_ads_v1.cc(161)] Get eligible ads for untargeted segment
[7543:7543:0718/173421.412181:VERBOSE2:exclusion_rules_base.cc(126)] campaignId f74b3bb4-8087-4084-b8be-bd2c9f23f7b3 has exceeded the dailyCap frequency cap
[7543:7543:0718/173421.412648:VERBOSE1:seen_advertisers.h(29)] All new_tab_page_ad advertisers have been shown, so round robin
[7543:7543:0718/173421.413092:VERBOSE1:client_state_manager.cc(463)] Resetting seen new_tab_page_ad advertisers
[7543:7543:0718/173421.414048:VERBOSE1:seen_ads.h(29)] All new_tab_page_ad ads have been shown, so round robin
[7543:7543:0718/173421.415333:VERBOSE1:client_state_manager.cc(426)] Resetting seen new_tab_page_ads
[7543:7543:0718/173421.422661:VERBOSE1:eligible_new_tab_page_ads_v1.cc(177)] No eligible ads out of 2 ads for untargeted segment
[7543:7543:0718/173421.423168:VERBOSE1:new_tab_page_ad_serving.cc(84)] New tab page ad not served: No eligible ads found
[7543:7543:0718/173421.425104:VERBOSE3:new_tab_page_ad_event_viewed.cc(24)] Viewed new tab page ad with placement id 36ba06d2-fd01-4fc8-9e78-b4283f6a6a7b and creative instance id 04af6c03-deed-4d6d-be5d-c11a9817e1de
[7543:7543:0718/173421.444652:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event
[7543:7543:0718/173421.495336:VERBOSE3:account.cc(164)] Successfully processed deposit for new_tab_page_ad with creative instance id 04af6c03-deed-4d6d-be5d-c11a9817e1de and view valued at 0.01
[7543:7543:0718/173421.495510:VERBOSE1:confirmations.cc(61)] Confirming view for new_tab_page_ad with transaction id 647eb131-b9c0-433e-9d12-4a069c4a6cd9 and creative instance id 04af6c03-deed-4d6d-be5d-c11a9817e1de
[7543:7543:0718/173421.508919:VERBOSE1:redeem_unblinded_token.cc(50)] Redeem unblinded token
[7543:7543:0718/173421.511686:VERBOSE1:redeem_unblinded_token.cc(71)] CreateConfirmation
[7543:7543:0718/173421.516225:VERBOSE2:redeem_unblinded_token.cc(72)] POST /v2/confirmation/{confirmation_id}/{credential}
[7543:7543:0718/173421.516869:VERBOSE6:redeem_unblinded_token.cc(76)] URL Request:
  URL: https://anonymous.ads.brave.com/v2/confirmation/e6e72b7e-353e-4fb7-8903-ed2cf5c2fc22/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlbnNcIjpbXCIyTmRHR2VxMlJ2eXlqR2c2bjdmcVFxdXE4YlFLNlVERkFZYkhmV0dnYkZ3PVwiXSxcImJ1aWxkQ2hhbm5lbFwiOlwiYmV0YVwiLFwiY2F0YWxvZ1wiOlt7XCJpZFwiOlwiYTk1ZWFiYjRlNmIwYjk0ZjcwMDZjMzk0ZWZmNzlhZmNjODdiZjk4M1wifV0sXCJjcmVhdGVkQXRUaW1lc3RhbXBcIjpcIjIwMjItMDctMThUMTU6MDA6MDAuMDAwWlwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCIwNGFmNmMwMy1kZWVkLTRkNmQtYmU1ZC1jMTFhOTgxN2UxZGVcIixcIm9keXNzZXlcIjpcImhvc3RcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwicHVibGljS2V5XCI6XCJvTXg4aFc2dzh3L0FVR29KTUFNYnJkZVYxRm9xclJrb1IzQlZhKzVsRERrPVwiLFwic3R1ZGllc1wiOlt7XCJncm91cFwiOlwiVHJpZ2dlcnM9TlRQU0kvVGltZVdpbmRvdz0xNW0vVGhyZXNob2xkPTAuMC9JZGxlVGltZVRocmVzaG9sZD01c1wiLFwibmFtZVwiOlwiQnJhdmVBZHMuVXNlckFjdGl2aXR5U3R1ZHlcIn1dLFwic3lzdGVtVGltZXN0YW1wXCI6XCIyMDIyLTA3LTE4VDE1OjAwOjAwLjAwMFpcIixcInR5cGVcIjpcInZpZXdcIixcInZlcnNpb25OdW1iZXJcIjpcIjEwMy4wLjUwNjAuMTE0XCJ9Iiwic2lnbmF0dXJlIjoiZ3dJalJyeVh5MTRMdkdDMmQrTmx1bXNCTEdmbkVYajVxazFOY1ZZWWVLRHlGb245RDJFUDQ5cWtva3NqWjhROEoyZWorVzd3T243RFZQYUpOTzZMaFE9PSIsInQiOiIzL2J3N2ZpUlZ3OU9uK2xnL2dmejNpVEJuUmJOVk5RbGVMVGhrUk9OWWdpd3N2YldlalR5WXJLRXFhVGF2cVRzOFV0Zm9kWXNxT1M4eWpndmsyWko0Zz09In0=
  Content: {"blindedPaymentTokens":["2NdGGeq2RvyyjGg6n7fqQquq8bQK6UDFAYbHfWGgbFw="],"buildChannel":"beta","catalog":[{"id":"a95eabb4e6b0b94f7006c394eff79afcc87bf983"}],"createdAtTimestamp":"2022-07-18T15:00:00.000Z","creativeInstanceId":"04af6c03-deed-4d6d-be5d-c11a9817e1de","odyssey":"host","payload":{},"platform":"linux","publicKey":"oMx8hW6w8w/AUGoJMAMbrdeV1FoqrRkoR3BVa+5lDDk=","studies":[{"group":"Triggers=NTPSI/TimeWindow=15m/Threshold=0.0/IdleTimeThreshold=5s","name":"BraveAds.UserActivityStudy"}],"systemTimestamp":"2022-07-18T15:00:00.000Z","type":"view","versionNumber":"103.0.5060.114"}
  Content Type: application/json
  Method: kPost
[7543:7543:0718/173421.727484:VERBOSE2:tab_manager.cc(158)] Tab id 14 HTML content changed
[7543:7543:0718/173421.744543:VERBOSE1:conversions.cc(238)] URL is not supported for conversions
[7543:7543:0718/173421.745162:VERBOSE2:tab_manager.cc(142)] Tab id 14 text content changed
[7543:7543:0718/173421.745727:VERBOSE1:purchase_intent_processor.cc(240)] chrome scheme is not supported for processing purchase intent
[7543:7543:0718/173421.746407:VERBOSE1:text_classification_processor.cc(105)] chrome scheme is not supported for processing text content
[7543:7543:0718/173421.783565:VERBOSE1:redeem_unblinded_token.cc(87)] OnCreateConfirmation
[7543:7543:0718/173421.783813:VERBOSE6:redeem_unblinded_token.cc(89)] URL Response:
  URL: https://anonymous.ads.brave.com/v2/confirmation/e6e72b7e-353e-4fb7-8903-ed2cf5c2fc22/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlbnNcIjpbXCIyTmRHR2VxMlJ2eXlqR2c2bjdmcVFxdXE4YlFLNlVERkFZYkhmV0dnYkZ3PVwiXSxcImJ1aWxkQ2hhbm5lbFwiOlwiYmV0YVwiLFwiY2F0YWxvZ1wiOlt7XCJpZFwiOlwiYTk1ZWFiYjRlNmIwYjk0ZjcwMDZjMzk0ZWZmNzlhZmNjODdiZjk4M1wifV0sXCJjcmVhdGVkQXRUaW1lc3RhbXBcIjpcIjIwMjItMDctMThUMTU6MDA6MDAuMDAwWlwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCIwNGFmNmMwMy1kZWVkLTRkNmQtYmU1ZC1jMTFhOTgxN2UxZGVcIixcIm9keXNzZXlcIjpcImhvc3RcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwicHVibGljS2V5XCI6XCJvTXg4aFc2dzh3L0FVR29KTUFNYnJkZVYxRm9xclJrb1IzQlZhKzVsRERrPVwiLFwic3R1ZGllc1wiOlt7XCJncm91cFwiOlwiVHJpZ2dlcnM9TlRQU0kvVGltZVdpbmRvdz0xNW0vVGhyZXNob2xkPTAuMC9JZGxlVGltZVRocmVzaG9sZD01c1wiLFwibmFtZVwiOlwiQnJhdmVBZHMuVXNlckFjdGl2aXR5U3R1ZHlcIn1dLFwic3lzdGVtVGltZXN0YW1wXCI6XCIyMDIyLTA3LTE4VDE1OjAwOjAwLjAwMFpcIixcInR5cGVcIjpcInZpZXdcIixcInZlcnNpb25OdW1iZXJcIjpcIjEwMy4wLjUwNjAuMTE0XCJ9Iiwic2lnbmF0dXJlIjoiZ3dJalJyeVh5MTRMdkdDMmQrTmx1bXNCTEdmbkVYajVxazFOY1ZZWWVLRHlGb245RDJFUDQ5cWtva3NqWjhROEoyZWorVzd3T243RFZQYUpOTzZMaFE9PSIsInQiOiIzL2J3N2ZpUlZ3OU9uK2xnL2dmejNpVEJuUmJOVk5RbGVMVGhrUk9OWWdpd3N2YldlalR5WXJLRXFhVGF2cVRzOFV0Zm9kWXNxT1M4eWpndmsyWko0Zz09In0=
  Response Status Code: 201
  Response: {"id":"e6e72b7e-353e-4fb7-8903-ed2cf5c2fc22","payload":{},"createdAt":"2022-07-18T15:34:21.325Z","type":"view","modifiedAt":"2022-07-18T15:34:21.325Z","creativeInstanceId":"04af6c03-deed-4d6d-be5d-c11a9817e1de"}
[7543:7543:0718/173421.784004:VERBOSE1:redeem_unblinded_token.cc(121)] FetchPaymentToken
[7543:7543:0718/173421.784089:VERBOSE2:redeem_unblinded_token.cc(122)] GET /v2/confirmation/{confirmation_id}/paymentToken
[7543:7543:0718/173421.784157:VERBOSE6:redeem_unblinded_token.cc(126)] URL Request:
  URL: https://anonymous.ads.brave.com/v2/confirmation/e6e72b7e-353e-4fb7-8903-ed2cf5c2fc22/paymentToken
  Method: kGet
[7543:7543:0718/173421.835339:VERBOSE1:uphold.cc(114)] Uphold wallet is not VERIFIED.
[7543:7543:0718/173422.009209:VERBOSE1:redeem_unblinded_token.cc(137)] OnFetchPaymentToken
[7543:7543:0718/173422.009838:VERBOSE6:redeem_unblinded_token.cc(139)] URL Response:
  URL: https://anonymous.ads.brave.com/v2/confirmation/e6e72b7e-353e-4fb7-8903-ed2cf5c2fc22/paymentToken
  Response Status Code: 202
  Response: {"error":"Payment Tokens are not ready","statusCode":202}
[7543:7543:0718/173422.011795:VERBOSE1:redeem_unblinded_token.cc(157)] Payment token is not ready
[7543:7543:0718/173422.012378:VERBOSE1:redeem_unblinded_token.cc(384)] Failed to redeem unblinded token for new_tab_page_ad with confirmation id e6e72b7e-353e-4fb7-8903-ed2cf5c2fc22, transaction id 647eb131-b9c0-433e-9d12-4a069c4a6cd9, creative instance id 04af6c03-deed-4d6d-be5d-c11a9817e1de and view
[7543:7543:0718/173422.014119:VERBOSE1:confirmations.cc(213)] Added view confirmation for new_tab_page_ad with id e6e72b7e-353e-4fb7-8903-ed2cf5c2fc22, transaction id 647eb131-b9c0-433e-9d12-4a069c4a6cd9 and creative instance id 04af6c03-deed-4d6d-be5d-c11a9817e1de to the confirmations queue
[7543:7543:0718/173422.024590:VERBOSE1:refill_unblinded_tokens.cc(93)] No need to refill unblinded tokens as we already have 43 unblinded tokens which is above the minimum threshold of 20
[7543:7543:0718/173422.026313:VERBOSE1:confirmations.cc(100)] Retry sending failed confirmations in 0 godzin, 0 minut i 4 sekundy at 17:34:26,016
[7543:7543:0718/173426.019056:VERBOSE1:confirmations.cc(108)] Retry sending failed confirmations
[7543:7543:0718/173426.019395:VERBOSE1:confirmations.cc(237)] Removed view confirmation for new_tab_page_ad with id e6e72b7e-353e-4fb7-8903-ed2cf5c2fc22, transaction id 647eb131-b9c0-433e-9d12-4a069c4a6cd9 and creative instance id 04af6c03-deed-4d6d-be5d-c11a9817e1de from the confirmations queue
[7543:7543:0718/173426.020167:VERBOSE1:redeem_unblinded_token.cc(50)] Redeem unblinded token
[7543:7543:0718/173426.025022:VERBOSE1:redeem_unblinded_token.cc(121)] FetchPaymentToken
[7543:7543:0718/173426.025228:VERBOSE2:redeem_unblinded_token.cc(122)] GET /v2/confirmation/{confirmation_id}/paymentToken
[7543:7543:0718/173426.025390:VERBOSE6:redeem_unblinded_token.cc(126)] URL Request:
  URL: https://anonymous.ads.brave.com/v2/confirmation/e6e72b7e-353e-4fb7-8903-ed2cf5c2fc22/paymentToken
  Method: kGet
[7543:7543:0718/173426.436856:VERBOSE1:redeem_unblinded_token.cc(137)] OnFetchPaymentToken
[7543:7543:0718/173426.437441:VERBOSE6:redeem_unblinded_token.cc(139)] URL Response:
  URL: https://anonymous.ads.brave.com/v2/confirmation/e6e72b7e-353e-4fb7-8903-ed2cf5c2fc22/paymentToken
  Response Status Code: 200
  Response: {"id":"e6e72b7e-353e-4fb7-8903-ed2cf5c2fc22","createdAt":"2022-07-18T15:34:21.325Z","type":"view","modifiedAt":"2022-07-18T15:34:23.456Z","creativeInstanceId":"04af6c03-deed-4d6d-be5d-c11a9817e1de","paymentToken":{"publicKey":"JlOezORiqLkFkvapoNRGWcMH3/g09/7M2UPEwMjRpFE=","batchProof":"OaS3SWPvqChUccTT8q5wq+ZBGmCqyaXwejmbf5qrwQef0Stk7HBjqVXd5bI2Q+de0r7YFsr8RdB/WlDaBJdjCg==","signedTokens":["svCKBvAuI5OEE2p8BauC+e2wpZ9pkUfqaS9uf1wW9EI="]}}
[7543:7543:0718/173426.441664:VERBOSE1:redeem_unblinded_token.cc(368)] Successfully redeemed unblinded token for new_tab_page_ad with confirmation id e6e72b7e-353e-4fb7-8903-ed2cf5c2fc22, transaction id 647eb131-b9c0-433e-9d12-4a069c4a6cd9, creative instance id 04af6c03-deed-4d6d-be5d-c11a9817e1de and view

image

Expected result:

NTP SI is shown when expected

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

Brave 1.42.65 Chromium: 103.0.5060.114 (Official Build) beta (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS Ubuntu 18.04 LTS

cc @rebron @tmancey @jsecretan @brave/qa-team
@aseren
Copy link

aseren commented Jul 18, 2022

@btlechowski, this is intentional, as we show prefetched NTP SI ads.

So on each 4th NTP refresh, we do the following:

  1. Check if there is a prefetched NTP SI ad that was triggered on the previous 4th refresh
  2. If there is a such SI ad, then show it on NTP
  3. Try to trigger a new NTP SI ad, if succeeded then prefetch it

@aseren aseren self-assigned this Jul 19, 2022
@aseren aseren changed the title NTP SI is not shown when triggered Try to trigger NTP SI on each NTP refresh Jul 19, 2022
@aseren aseren mentioned this issue Jul 19, 2022
Merged
25 tasks
aseren added a commit to brave/brave-core that referenced this issue Jul 19, 2022
@aseren
Try trigger NTPSI ad on each NTP refresh.
b8da1af 
fix brave/brave-browser#24107
aseren added a commit to brave/brave-core that referenced this issue Jul 21, 2022
@aseren
Try trigger NTPSI ad on each NTP refresh.
54106dd 
fix brave/brave-browser#24107
@brave-builds brave-builds added this to the 1.43.x - Nightly milestone Jul 21, 2022
aseren added a commit to brave/brave-core that referenced this issue Jul 21, 2022
@aseren
Try trigger NTPSI ad on each NTP refresh.
aea51b2 
fix brave/brave-browser#24107
@aseren aseren mentioned this issue Jul 21, 2022
Merged
25 tasks
@kjozwiak
Copy link
Member

The above requires 1.42.78 or higher for 1.42.x verification 👍

@btlechowski
Copy link
Author

btlechowski commented Jul 26, 2022 •
edited
Loading

Verification passed on

Brave 1.42.78 Chromium: 103.0.5060.134 (Official Build) beta (64-bit)
Revision 8ec6fce403b3feb0869b0732eda8bd95011d333c-refs/branch-heads/5060@{#1262}
OS Ubuntu 18.04 LTS

ads enabled

Verified attempt to serve the ad is made every NTP load
Verified when ad is served (prefetched) no longer
Verified ad is shown (view event) on 2nd, 6th, 10th etc NTP load

1st NTP - ad is served (prefetched):

[5090:5090:0726/225657.850262:VERBOSE1:eligible_new_tab_page_ads_v1.cc(38)] Get eligible new tab page ads:
[5090:5090:0726/225657.854433:VERBOSE1:eligible_new_tab_page_ads_v1.cc(161)] Get eligible ads for untargeted segment
[5090:5090:0726/225657.864501:VERBOSE2:priority.h(33)] 3 ads with a priority of 1 in bucket 1
[5090:5090:0726/225657.864659:VERBOSE1:eligible_new_tab_page_ads_v1.cc(181)] 3 eligible ads out of 3 ads for untargeted segment
[5090:5090:0726/225657.864757:VERBOSE1:new_tab_page_ad_serving.cc(89)] Found 3 eligible ads
[5090:5090:0726/225657.864839:VERBOSE1:new_tab_page_ad_serving.cc(139)] Serving new tab page ad:
  placementId: 178bf999-5bd2-407c-a6c6-5f0c15c48cec
  creativeInstanceId: 4cb59b95-97d7-48b7-9881-1c106a15bc86
  creativeSetId: c39d0fb4-f793-4033-a571-aba771955a53
  campaignId: 1f03a7e4-09c0-4df9-8c58-80b0409409dd
  advertiserId: 216c5e8c-434d-4c72-a9c5-3a11343dde48
  segment: untargeted
  companyName: Brave Wallet
  imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/d2224b33-d8d5-4fd8-97cf-9afd7b366b93.png
  alt: Brave Wallet - Explore Solana dApps with Brave Wallet. - Learn More
  targetUrl: https://brave.com/1.41-release/?source=sponsoredimage20220726
  wallpaperImageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/f4ea4bc4-efc2-491b-be0c-8ba71365bc94.jpg
  wallpaperFocalPointX: 1280
  wallpaperFocalPointY: 720
[5090:5090:0726/225657.865178:VERBOSE1:new_tab_page_ad_serving.cc(101)] Served new tab page ad
[5090:5090:0726/225657.870449:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 178bf999-5bd2-407c-a6c6-5f0c15c48cec and creative instance id 4cb59b95-97d7-48b7-9881-1c106a15bc86
[5090:5090:0726/225657.882393:VERBOSE6:new_tab_page_ad_event_served.cc(31)] Successfully logged new tab page ad served event

2nd NTP - ad is viewed (shown):

[5090:5090:0726/225706.263346:VERBOSE3:new_tab_page_ad_event_viewed.cc(24)] Viewed new tab page ad with placement id 178bf999-5bd2-407c-a6c6-5f0c15c48cec and creative instance id 4cb59b95-97d7-48b7-9881-1c106a15bc86
[5090:5090:0726/225706.279448:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event

3rd NTP - attempt to serve the ad is made but blocked due frequency capping

[5090:5090:0726/225709.558895:VERBOSE2:permission_rule_util.cc(25)] New tab page ad cannot be shown as minimum wait time has not passed
[5090:5090:0726/225709.559336:VERBOSE1:new_tab_page_ad_serving.cc(66)] New tab page ad not served: Not allowed due to permission rules

4th NTP - attempt to serve the ad is made but blocked due frequency capping

[5090:5090:0726/225711.909250:VERBOSE2:permission_rule_util.cc(25)] New tab page ad cannot be shown as minimum wait time has not passed
[5090:5090:0726/225711.909517:VERBOSE1:new_tab_page_ad_serving.cc(66)] New tab page ad not served: Not allowed due to permission rules

5th NTP - ad served

[5090:5090:0726/225915.613982:VERBOSE1:eligible_new_tab_page_ads_v1.cc(38)] Get eligible new tab page ads:
[5090:5090:0726/225915.616350:VERBOSE1:eligible_new_tab_page_ads_v1.cc(161)] Get eligible ads for untargeted segment
[5090:5090:0726/225915.621519:VERBOSE2:exclusion_rules_base.cc(126)] creativeInstanceId 4cb59b95-97d7-48b7-9881-1c106a15bc86 has exceeded the perHour frequency cap
[5090:5090:0726/225915.622201:VERBOSE1:seen_advertisers.h(29)] All new_tab_page_ad advertisers have been shown, so round robin
[5090:5090:0726/225915.622618:VERBOSE1:client_state_manager.cc(463)] Resetting seen new_tab_page_ad advertisers
[5090:5090:0726/225915.624089:VERBOSE2:priority.h(33)] 2 ads with a priority of 1 in bucket 1
[5090:5090:0726/225915.629905:VERBOSE1:eligible_new_tab_page_ads_v1.cc(181)] 2 eligible ads out of 3 ads for untargeted segment
[5090:5090:0726/225915.630464:VERBOSE1:new_tab_page_ad_serving.cc(89)] Found 2 eligible ads
[5090:5090:0726/225915.630991:VERBOSE1:new_tab_page_ad_serving.cc(139)] Serving new tab page ad:
  placementId: 991f1dc2-c3a4-44c2-b1dd-a94de323f327
  creativeInstanceId: 42cb1bc0-0483-4b1e-8f23-7761c8152909
  creativeSetId: c39d0fb4-f793-4033-a571-aba771955a53
  campaignId: 1f03a7e4-09c0-4df9-8c58-80b0409409dd
  advertiserId: 216c5e8c-434d-4c72-a9c5-3a11343dde48
  segment: untargeted
  companyName: Brave Wallet
  imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/d2224b33-d8d5-4fd8-97cf-9afd7b366b93.png
  alt: Brave Wallet - Explore Solana dApps with Brave Wallet. - Learn More
  targetUrl: https://brave.com/1.41-release/?source=sponsoredimage20220726
  wallpaperImageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/07abafd8-541a-4c04-8240-46cf673e9723.jpg
  wallpaperFocalPointX: 1280
  wallpaperFocalPointY: 720
[5090:5090:0726/225915.634970:VERBOSE1:new_tab_page_ad_serving.cc(101)] Served new tab page ad
[5090:5090:0726/225915.645945:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 991f1dc2-c3a4-44c2-b1dd-a94de323f327 and creative instance id 42cb1bc0-0483-4b1e-8f23-7761c8152909
[5090:5090:0726/225915.691157:VERBOSE6:new_tab_page_ad_event_served.cc(31)] Successfully logged new tab page ad served event

6th NTP - ad viewed

[5090:5090:0726/225920.366980:VERBOSE3:new_tab_page_ad_event_viewed.cc(24)] Viewed new tab page ad with placement id 991f1dc2-c3a4-44c2-b1dd-a94de323f327 and creative instance id 42cb1bc0-0483-4b1e-8f23-7761c8152909
[5090:5090:0726/225920.399785:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event

7th NTP - ad is served

[5090:5090:0726/230151.642789:VERBOSE1:eligible_new_tab_page_ads_v1.cc(38)] Get eligible new tab page ads:
[5090:5090:0726/230151.645166:VERBOSE1:eligible_new_tab_page_ads_v1.cc(161)] Get eligible ads for untargeted segment
[5090:5090:0726/230151.648416:VERBOSE2:exclusion_rules_base.cc(126)] creativeInstanceId 42cb1bc0-0483-4b1e-8f23-7761c8152909 has exceeded the perHour frequency cap
[5090:5090:0726/230151.649364:VERBOSE2:exclusion_rules_base.cc(126)] creativeInstanceId 4cb59b95-97d7-48b7-9881-1c106a15bc86 has exceeded the perHour frequency cap
[5090:5090:0726/230151.649516:VERBOSE1:seen_advertisers.h(29)] All new_tab_page_ad advertisers have been shown, so round robin
[5090:5090:0726/230151.649663:VERBOSE1:client_state_manager.cc(463)] Resetting seen new_tab_page_ad advertisers
[5090:5090:0726/230151.650307:VERBOSE2:priority.h(33)] 1 ads with a priority of 1 in bucket 1
[5090:5090:0726/230151.650495:VERBOSE1:eligible_new_tab_page_ads_v1.cc(181)] 1 eligible ads out of 3 ads for untargeted segment
[5090:5090:0726/230151.650713:VERBOSE1:new_tab_page_ad_serving.cc(89)] Found 1 eligible ads
[5090:5090:0726/230151.650899:VERBOSE1:new_tab_page_ad_serving.cc(139)] Serving new tab page ad:
  placementId: 35269f9b-440b-4438-9907-d6fb9e1e5752
  creativeInstanceId: 026f62e8-ad7e-4175-b695-646c938d580b
  creativeSetId: c39d0fb4-f793-4033-a571-aba771955a53
  campaignId: 1f03a7e4-09c0-4df9-8c58-80b0409409dd
  advertiserId: 216c5e8c-434d-4c72-a9c5-3a11343dde48
  segment: untargeted
  companyName: Brave Wallet
  imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/d2224b33-d8d5-4fd8-97cf-9afd7b366b93.png
  alt: Brave Wallet - Explore Solana dApps with Brave Wallet. - Learn More
  targetUrl: https://brave.com/1.41-release/?source=sponsoredimage20220726
  wallpaperImageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/24ffe4f1-eaab-44a8-bbd3-61da2e1be345.jpg
  wallpaperFocalPointX: 1280
  wallpaperFocalPointY: 720
[5090:5090:0726/230151.651969:VERBOSE1:new_tab_page_ad_serving.cc(101)] Served new tab page ad
[5090:5090:0726/230151.687065:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 35269f9b-440b-4438-9907-d6fb9e1e5752 and creative instance id 026f62e8-ad7e-4175-b695-646c938d580b
[5090:5090:0726/230151.714992:VERBOSE6:new_tab_page_ad_event_served.cc(31)] Successfully logged new tab page ad served event

8th, 9th - ad is already served so we do nothing

10th and is viewed

[5090:5090:0726/230301.592081:VERBOSE3:new_tab_page_ad_event_viewed.cc(24)] Viewed new tab page ad with placement id 35269f9b-440b-4438-9907-d6fb9e1e5752 and creative instance id 026f62e8-ad7e-4175-b695-646c938d580b
[5090:5090:0726/230301.619147:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event
[5090:5090:0726/230301.658108:VERBOSE3:account.cc(164)] Successfully processed deposit for new_tab_page_ad with creative instance id 026f62e8-ad7e-4175-b695-646c938d580b and view valued at 0.01
[5090:5090:0726/230301.658649:VERBOSE1:confirmations.cc(61)] Confirming view for new_tab_page_ad with transaction id e47ebb56-058f-4575-8870-6d8f073816f1 and creative instance id 026f62e8-ad7e-4175-b695-646c938d580b

ads disabled

Verified ads are shown but user is not paid

1st ad not shown
2nd ad shown
3rd ad not shown
4th ad not shown
5th ad not shown
6th ad shown
7th ad not shown
8th ad not shown
9th ad not shown
10th ad shown

aseren added a commit to brave/brave-core that referenced this issue Aug 4, 2022
@aseren
Try trigger NTPSI ad on each NTP refresh.
85de070 
fix brave/brave-browser#24107
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
feature/ads OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA/Test-Plan-Specified QA/Yes release/blocking release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.42.x - Release
Development

Successfully merging a pull request may close this issue.

Try trigger NTPSI ad on each NTP refresh. brave/brave-core
4 participants
@kjozwiak @btlechowski @brave-builds @aseren