Skip to content

Single typo #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 27 commits into from
Closed

Single typo #630

wants to merge 27 commits into from

Conversation

bordalix
Copy link
Collaborator

No description provided.

sekulicd and others added 27 commits May 14, 2025 15:49
* btc-wallet server detach init

* detach btc wallet

* pr review

* fixes

* fixes

* fix

* restore .run

* Fixes

* Update gh actions

* Polish

* Fix

* Revert

* Polish docker compose file

* trigger ci

---------

Co-authored-by: altafan <[email protected]>
* Drop wasm

* Drop descriptor

* Drop ocean

* Drop descriptor

* Add build of ark sdk binary

* Go work sync

* Polish
* refactor: arknote are fake vtxos

* preimage : use fixed length array

* NoteClosure.WitnessSize : use preimageSize constant

* interface : use getters

---------

Co-authored-by: altafan <[email protected]>
* Fix start up and tear down of external wallet

* Fix  envs

* Refactor domain & Update tx builder and repo impls

* Add ports.TxDecoder

* Add domain.OffchainTx, repo and related impl & Move update of proj store to repo manager & Drop use of useless custodialVtxos

* Dockerize migrate

* Polish

* Update Makefile

* Polish

* Go work sync

* Fix tests

* Fixes after review

* Fix
* P2A in vtxo tree and redeem txs

* update validation.go

* fix conflict

* fix linter error

* fix test unilateral exit

* fix bitcoin_wallet.go

* e2e test: faucet onchain

* fixes

* NewAddresses returns onchain P2TR addresses

* e2e tests: add TODOs

* fixes after reviews
* DeleteIntent RPC

* delete intent by bip322 proof

* add DeleteIntent to sdk client

* pr review
* add checkpoint

* remove fees in forfeit transactions

* go work sync

* react to fraud with checkpoint

* update e2e test

* go work sync

* e2e test: fix linter errors

* fix builder_test.go

* fix permissions.go

* remove fmt.Print

* rename redeemTx variables to virtualTx

* rename "findFirstRoundToExpire"

* pending.go: move to top BuildOffchainTx

* pending.go: renaming and fixes

* ark-wallet, config.go: make EsploraURL mandatory

* wallet_service.go: withUncomfired var

* pending.go: typo

* Update pkg/ark-wallet/internal/config/config.go

Co-authored-by: Pietralberto Mazza <[email protected]>
Signed-off-by: Louis Singer <[email protected]>

* wallet_service.go: improve readability

* fraud.go : tickerInterval global vars

* main.go: renaming

* pending.go: check inputs amount = outputs amount

* offchain_tx_test.go: order test case

* blockscheduler: use log alias

* fix domain.OffchainTxRequest event

* Update server/internal/core/application/service.go

Co-authored-by: Pietralberto Mazza <[email protected]>
Signed-off-by: Louis Singer <[email protected]>

* Update server/internal/core/application/service.go

Co-authored-by: Pietralberto Mazza <[email protected]>
Signed-off-by: Louis Singer <[email protected]>

* Update server/test/e2e/test_utils.go

Co-authored-by: Pietralberto Mazza <[email protected]>
Signed-off-by: Louis Singer <[email protected]>

* e2e test: add BumpAndBroadcast util func

* pending.go: rename buildCheckpointTx

---------

Signed-off-by: Louis Singer <[email protected]>
Co-authored-by: Pietralberto Mazza <[email protected]>
* improve event parser

* update domain tests

* Fix

---------

Co-authored-by: altafan <[email protected]>
)

* add ConfirmRegistration RPC

* remove Ping

* update proto

* typo "intent_id_hashes"

* remove duplicate

* add getCurrentRound

* revert locks on currentRound

* revert SignRoundTx

* fix e2e test

* config: add RoundMinParticipantsCount

* simplify startConfirmation

* clean round_timing.go

* improve confirmationSession

* fix boardingExitDelay

* clean app service funcs

* BatchStarted event: update comment

* remove math.Max

* remove GetRound call + fix newBoardingInput

* remove fmt.Print

* remove log when confirmRegistration fails

* TransportClient: remove unused GetEventStream parameter

* service.go: replace time.Sleep by time.After

* service.go: improve tx request error msg

* use time.After instead of timers

* service.go : move propagate functions at the same place

* CI: integration, capture Arkd logs on failure

* RegisterIntent log.Debug

* revert SignRoundTx currentRound lock
* sub-dust vtxo

* renaming

* fix min amount config

* Update compose file

* Fix

---------

Co-authored-by: altafan <[email protected]>
* DeleteIntent test and improvements

* DeleteIntentRequest: use oneof

* rework after reviews
* add BatchTreeEvent

* client.go : clean unexported functions

* add BatchTreeSignature event

* client.go: return error if BatchIndex != 0

* Add docker-compose.yml

* Add volumes

* Fix

* Drop compose file

---------

Co-authored-by: altafan <[email protected]>
* improve startup logs

* round percentage
* init pg

* pg db impl

* fix

* go sync

* inmemory offchaintxmap added to remove timeouts

* fix

* pr review

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* sync

* gitignore

* fix

* Fixes

* Lint

* Fix envs

---------

Co-authored-by: altafan <[email protected]>
* watermill event repository

* support postgres event repo type

* add ARK_EVENT_DB_URL

* revert e2e test to sqlite

* server Makefile: update .PHONY
* remove signing_type

* fix nbCosigners

* cleaning
* set current round CommitmentTx even if there is no vtxo tree

* add without_vtxo_change test case in TestCollaborativeExit
* init

* live store, inmemory

* tmp

* tmp

* tmp

* temp

* tmp

* Fixes (#2)

* Fixes

* Uncomment TestMain

* Lint

* redis live store

* fix

* fix

* fix

* fix lint

* fix

* pr review

* fix

* fix

* fix

* fix

* fix

* fix

* Sync with next-version (#3)

* Support uint8 CLTV locktime (#610)

* Remove SIGNING_TYPE (keep sign branch only) (#617)

* remove signing_type

* fix nbCosigners

* cleaning

* Fixes

---------

Co-authored-by: louisinger <[email protected]>

* Fix watchSessionCompleted

* Fix push intent retry

* Fix GetRoundStats pg query

---------

Co-authored-by: Pietralberto Mazza <[email protected]>
Co-authored-by: louisinger <[email protected]>
* Api refactor:
* Rename round -> commitment/batch
* Rename vtxo.pubkey -> vtxo.script
* Rename events
* Rename redeem -> ark
* Rename request -> intent
* Merge RoundTransaction, RedeemTransaction -> TxNotification
* Merge indexer GetVtxos, GetVtxosByOutpoint -> GetVtxos
* Drop explorer
* Move Withdraw from admin to wallet

* Update server:
* app: forward tx event to indexer channel & merge RoundTransactionEvent, RedeemTransactionEvent -> TransactionEvent
* interface: update handlers and permissions & drop explorer
* e2e tests: update tests & replace explorer apis with indexer apis

* Refactor SDK:
* Rename round -> commitment/batch
* Rename shared output -> batch output
* Rename virtual/redeem tx -> ark tx
* Rename vtxo pubkey -> script
* Rename pending -> preconfirmed
* Update transport and indexer clients
* Add indexer.GetFullVtxoTree
* Drop client.Vtxo and indexer.Vtxo and use only types.Vtxo
* Use indexer for NotifyIncomingFunds
* Move util functions to utils.go
* Update stores

* Go work sync

* Remove t.Skip()

* Fix param order

* Drop BatchEvent interface

* Drop client.Output

* Fixes and Lint

* Fixes

* Fixes
* Verify exit closures & Verify CSV in RegisterIntent

* Fix time.Now

* Fixes
* check if channel is nil before closing it

* fixes

* Tidy up

---------

Co-authored-by: altafan <[email protected]>
* add TxGraph, remove TxTree

* fix linter

* fix server unit test

* fix common unit test

* add Txid to TxGraphChunk

* tidy up builder.go

* remove musig2.go marshaller vars

* tidy up nonces and sigs types

* renaming

* remove reflect

* tree/builder.go: add node.graph() method

* tree/tx_graph.go: use B64Encode()

* client-sdk/client: add Txid to BatchTreeEvent

* always use json.Marshall/Unmarshall

* service_test: move util function

* service_test: cleaning

* live-store: use connector chunks

* fix linter

* postgres

* tx_graph: remove crawl method

* tx_graph: clean

* Update common/tree/tx_graph.go

Co-authored-by: Pietralberto Mazza <[email protected]>
Signed-off-by: louisinger <[email protected]>

* postgres migration: drop view before altering tables

* add nbOfOutputs check in tx_graph

* client-sdk/rest fix streaming endpoints

* Revert

* Fix intent cache

* Fix test

* Fix query

* Fix

---------

Signed-off-by: louisinger <[email protected]>
Co-authored-by: Pietralberto Mazza <[email protected]>
@bordalix bordalix requested a review from altafan June 23, 2025 11:10
@bordalix bordalix closed this Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants