Add 0-value P2A output to offchain transactions #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
altafan
reviewed
May 20, 2025
altafan
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds P2A to vtxo tree transactions and redeem txs. It breaks the "react to fraud" system, waiting for checkpoint (#491) to be implemented.
Remove min-relay-fee
Migrating to transaction version 3 allows to remove the min-relay-fee everywhere in the vtxo tree and ark transaction. It means no more fee estimation while building the tree or an offchain payment.
Pay to anchor bump
Because every VTXO and batch output is locked by relative CSV locktime, we need a 0-value P2A output in every transactions.
Unilateral exit UX
Bitcoin 0.29 allows broadcasting a package with the 1C1P limitation. It implies change in the unilateral exit because
ark redeem --forcehas to be called X times, where "X" is the number of transactions to put on chain.Bumping the anchor also requires onchain funds, that's why a simple P2TR account has been added to the CLI.
it closes #215
It closes #438
@altafan @Kukks please review