refactor arknote as fake vtxo #556
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is refactoring arknote. It also drops the "note" DB Table and repository.
breaking change.
Fake VTXO note
A note now looks like the following :
the string embed a 32 byte preimage & the value of the note (4 BE bytes).
When creating a note via
AdminService.CreateNotes
, the server adds adomain.Vtxo
to the database. This VTXO has an emptyroundTxId
field and is locked by a taproot pkscript with a unique tapscript:The fake vtxo is identified by the
preimageHash:0
outpoint.Thus, a note can be registered as input of the BIP322 intent transaction.
API changes
notes
fromRegisterIntent
RPCnotes
fromRegisterInputsForNextRound
RPCTxRequestInfo
messageBip322Signature
field.@Kukks @altafan please review