Api renaming #605
Merged
Api renaming #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekulicd
reviewed
Jun 12, 2025
louisinger
reviewed
Jun 12, 2025
* Rename round -> commitment/batch * Rename vtxo.pubkey -> vtxo.script * Rename events * Rename redeem -> ark * Rename request -> intent * Merge RoundTransaction, RedeemTransaction -> TxNotification * Merge indexer GetVtxos, GetVtxosByOutpoint -> GetVtxos * Drop explorer * Move Withdraw from admin to wallet
* app: forward tx event to indexer channel & merge RoundTransactionEvent, RedeemTransactionEvent -> TransactionEvent * interface: update handlers and permissions & drop explorer * e2e tests: update tests & replace explorer apis with indexer apis
* Rename round -> commitment/batch * Rename shared output -> batch output * Rename virtual/redeem tx -> ark tx * Rename vtxo pubkey -> script * Rename pending -> preconfirmed * Update transport and indexer clients * Add indexer.GetFullVtxoTree * Drop client.Vtxo and indexer.Vtxo and use only types.Vtxo * Use indexer for NotifyIncomingFunds * Move util functions to utils.go * Update stores
louisinger
requested changes
Jun 19, 2025
louisinger
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains renaming for the apis defined in the protos, client and indexer of the sdk, the interface layer of the server and some functions of the application one.
This also drops the explorer proto. In the sdk it's been replaced with the usage of the indexer, as well as in tests.
Closes #583.
Closes #584.
Please @louisinger @sekulicd review.